Commitb407e8e

travisclagrone

authored and

bergmeister

committed

Actionabilize errors from incorrect settings files (#1263)

* Annotatively research current state of exception handling surrounding settings file load invocation* Throw a contextful terminating error if processing the argument of 'Invoke-ScriptAnalyzer -Settings' results in an exception* Refine id and category of error for when processing value of `Invoke-ScriptAnalyzer -Settings` results in an exception* Revert "Annotatively research current state of exception handling surrounding settings file load invocation"This reverts commit3bfd45b.* Do not attempt id and category inference for the error to throw when processing the argument of `Invoke-ScriptAnalyzer -Settings` results in an exception* Remove `using System.IO`* Revert "Remove `using System.IO`"This reverts commit88ab1ec.`using System.IO` is required in Engine\Settings.cs after all. The mainuse is for pre-existing unqualified references to the typeInvalidDataException.* Remove unused using after refactoring. Use more descriptive variable name and make error record arguments consistent with usage in other parts of the solution.

1 parentfd7663e commitb407e8eCopy full SHA for b407e8e

File tree

1 file changed

-5

lines changed

Engine/Commands
- InvokeScriptAnalyzerCommand.cs

1 file changed

-5

lines changed

`‎Engine/Commands/InvokeScriptAnalyzerCommand.cs‎`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -325,11 +325,13 @@ protected override void BeginProcessing()`
`325`	`325`	`?rulePaths`
`326`	`326`	`:rulePaths.Concat(settingsCustomRulePath).ToArray();`
`327`	`327`	`}`
`328`		`-catch`
	`328`	`+catch(Exceptionexception)`
`329`	`329`	`{`
`330`		`-this.WriteWarning(String.Format(CultureInfo.CurrentCulture,Strings.SettingsNotParsable));`
`331`		`-stopProcessing=true;`
`332`		`-return;`
	`330`	`+this.ThrowTerminatingError(newErrorRecord(`
	`331`	`+exception,`
	`332`	`+"SETTINGS_ERROR",`
	`333`	`+ErrorCategory.InvalidData,`
	`334`	`+this.settings));`
`333`	`335`	`}`
`334`	`336`
`335`	`337`	`ScriptAnalyzer.Instance.Initialize(`
`@@ -357,7 +359,7 @@ protected override void ProcessRecord()`
`357`	`359`	`{`
`358`	`360`	`ProcessPath();`
`359`	`361`	`}`
`360`		`-`
	`362`	`+`
`361`	`363`	`#if!PSV3`
`362`	`364`	`// TODO Support dependency resolution for analyzing script definitions`
`363`	`365`	`if(saveDscDependency)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb407e8e

File tree

1 file changed

1 file changed

`‎Engine/Commands/InvokeScriptAnalyzerCommand.cs‎`

0 commit comments