- Notifications
You must be signed in to change notification settings - Fork100
Fix 1908 - Version from API differs from manifest#1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Fix 1908 - Version from API differs from manifest#1911
Uh oh!
There was an error while loading.Please reload this page.
Conversation
o-l-a-v commentedNov 19, 2025
Tests: Suggestions on how to test this without adding test against |
anamnavi commentedDec 4, 2025
thanks for the PR@o-l-a-v . The team needs to consider the design for the issue and decide. The design your solution suggests will be considered too, but I think we should leverage the existing version parsing and metadata file prioritization code that is already used for Local file share repositories and refactor that code out to a shared location (if not already done) for it to be used here. We would also need to consider preview versions (which are stored differently in .psd1 files versus .nuspec files), a package containing multiple .psd1 files, etc. |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Prefer version from the
.psd1manifest file if the version returned from the repository API is different. ElseImport-Modulefails, saying the manifest is not valid.I used Copilot to mock up needed changes. I implemented and tested them with modifications myself. Built the module and thested
Install-PSResource, like linked issue described.PR Context
#1908
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.