Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix 1908 - Version from API differs from manifest#1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
o-l-a-v wants to merge2 commits intoPowerShell:master
base:master
Choose a base branch
Loading
fromo-l-a-v:fix-1908-version-from-api-differs-from-manifest

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-vo-l-a-v commentedNov 19, 2025
edited
Loading

PR Summary

Prefer version from the.psd1 manifest file if the version returned from the repository API is different. ElseImport-Module fails, saying the manifest is not valid.

I used Copilot to mock up needed changes. I implemented and tested them with modifications myself. Built the module and thestedInstall-PSResource, like linked issue described.

PR Context

#1908

PR Checklist

@o-l-a-v
Copy link
ContributorAuthor

Tests: Suggestions on how to test this without adding test againstpwsh.gallery for this specific case? 🤔

@anamnavi
Copy link
Member

thanks for the PR@o-l-a-v . The team needs to consider the design for the issue and decide. The design your solution suggests will be considered too, but I think we should leverage the existing version parsing and metadata file prioritization code that is already used for Local file share repositories and refactor that code out to a shared location (if not already done) for it to be used here. We would also need to consider preview versions (which are stored differently in .psd1 files versus .nuspec files), a package containing multiple .psd1 files, etc.

o-l-a-v reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@anamnavianamnaviAwaiting requested review from anamnavianamnavi is a code owner

@alericksonalericksonAwaiting requested review from alericksonalerickson is a code owner

@adityapatwardhanadityapatwardhanAwaiting requested review from adityapatwardhanadityapatwardhan is a code owner

@SydneyhSmithSydneyhSmithAwaiting requested review from SydneyhSmithSydneyhSmith is a code owner

@shammu1shammu1Awaiting requested review from shammu1shammu1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@o-l-a-v@anamnavi

[8]ページ先頭

©2009-2025 Movatter.jp