Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added support for AWS CodeArtifact#1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
austoonz wants to merge6 commits intoPowerShell:master
base:master
Choose a base branch
Loading
fromaustoonz:master

Conversation

@austoonz
Copy link

PR Summary

Adds support for AWS CodeArtifact NuGet v3 repositories.Resolves#1650.

PR Context

AWS CodeArtifact supports NuGet v3 feeds. This adds the features supported by AWS CodeArtifact to the PSResourceGet module.

PR Checklist

**Testing

This is both. I've added a unit test to ensure the fast-fail code path is not hit. I have also used this interactively. Examples below against a repository in my AWS account.

# Showing the resource repository# NOTE: My AWS AccountId has been changed...PS>Get-PSResourceRepository-Name AWSCodeArtifact|Select-Object-Property Name, UriName            Uri-------AWSCodeArtifact https://psrepo-123456789012.d.codeartifact.us-west-2.amazonaws.com/nuget/psrepo/v3/index.json# Showing `-Name '*'` worksPS>Find-PSResource-Credential$credential-Repository'AWSCodeArtifact'-Name'*'|Select-Object-Property Name, RepositoryName                   Repository--------------AWS.Tools.CodeArtifact AWSCodeArtifactAWS.Tools.Common       AWSCodeArtifactAWS.Tools.EC2          AWSCodeArtifactAWS.Tools.S3           AWSCodeArtifactConvert                AWSCodeArtifactFastPing               AWSCodeArtifactFileSystemHelpers      AWSCodeArtifact# Showing `-Name 'Prefix*'` worksPS>Find-PSResource-Credential$credential-Repository'AWSCodeArtifact'-Name'AWS.Tools.*'|Select-Object-Property Name, RepositoryName                   Repository--------------AWS.Tools.CodeArtifact AWSCodeArtifactAWS.Tools.Common       AWSCodeArtifactAWS.Tools.EC2          AWSCodeArtifactAWS.Tools.S3           AWSCodeArtifact

@austoonz
Copy link
Author

@microsoft-github-policy-service agree

@austoonz
Copy link
Author

I've found an issue in theGetVersionedPackageEntriesFromSearchQueryResource() method with CodeArtifact, with theinitialCount value that's returned. This value is not necessarily accurate for the entire data set, and the default to retrieving 100 records at a time also doesn't work as intended.

In my clone I've changed the query logic to continue querying until no data is returned. I wanted to run that idea past those here given I don't have other NuGet v3 feeds to test against. Examplecommit.

@alerickson
Copy link
Member

/azp run PowerShell.PSResourceGet

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alerickson
Copy link
Member

/azp run PowerShell.PSResourceGet

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alerickson
Copy link
Member

/azp run PowerShell.PSResourceGet

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alerickson
Copy link
Member

/azp run PowerShell.PSResourceGet

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alericksonalericksonalerickson left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for AWS CodeArtifact

3 participants

@austoonz@alerickson@SydneyhSmith
[8]ページ先頭
©2009-2025 Movatter.jp