- Notifications
You must be signed in to change notification settings - Fork45
Fix property discovery on class-based resources WinPS adapter#879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix property discovery on class-based resources WinPS adapter#879
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@SteveL-MSFT, could you please let me know which of the other PRs goes first? Then I can fix the merge conflict and rewrite some of the logic :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add a test?
| DscResourceInfo = $DscResourceInfo | ||
| LastWriteTimes = $lastWriteTimes | ||
| }) | ||
| Type = "$moduleName/$($dscResource.Name)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This indentation doesn't look right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't this double indented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
still there
Ready to go :) |
6fc6ecc toe557557Comparee557557 tof0c30ddComparef0c30dd tocdbb4b1Compare| DscResourceInfo = $DscResourceInfo | ||
| LastWriteTimes = $lastWriteTimes | ||
| }) | ||
| Type = "$moduleName/$($dscResource.Name)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't this double indented?
Uh oh!
There was an error while loading.Please reload this page.
1af0044 tob602c8fCompare…sreyn/operation-methods into fix-class-property-discovery
| DscResourceInfo = $DscResourceInfo | ||
| LastWriteTimes = $lastWriteTimes | ||
| }) | ||
| Type = "$moduleName/$($dscResource.Name)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
still there
Somehow, the OTBS and auto-save do that double indentation. It should be good now. |
| [System.Management.Automation.Language.ParseError[]] $errors = $null | ||
| $ast = [System.Management.Automation.Language.Parser]::ParseFile($module, [ref]$tokens, [ref]$errors) | ||
| foreach ($e in $errors) { | ||
| $e | Out-String | Write-DscTrace -Operation Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If there are any errors, should we just exit with an exit code?
Uh oh!
There was an error while loading.Please reload this page.
82b9135Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This PR addresses issue#878. Note: there are no tests and might conflict with PR#877. Depending on these, I have to resolve the conflicts and add relevant tests.
PR Context