Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Check Type instance has DscResource attribute#812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SteveL-MSFT merged 1 commit intoPowerShell:mainfromhaodeon:fix/winPS-ClassBased
May 20, 2025

Conversation

haodeon
Copy link
Contributor

@haodeonhaodeon commentedMay 14, 2025•
edited
Loading

PR Summary

PR#797 introduced a workaround to detect if DSC resources wereClassBased. This PR adds an additional validation by checking the instance has theDscResource attribute.

PR Context

The workaround incorrectly setsImplementationDetail toClassBased when there is another type with the same name, likeTimeZone orEnvironment.

Gijsreyn reacted with rocket emoji
@Gijsreyn
Copy link
Contributor

Nice catch@haodeon!

@haodeonhaodeonforce-pushed thefix/winPS-ClassBased branch from00d97b2 toe7e6292CompareMay 15, 2025 03:47
@haodeonhaodeon changed the titlefix: Check instance properties have DscProperty attributefix: Check Type instance has DscResource attributeMay 15, 2025
@SteveL-MSFTSteveL-MSFT added this pull request to themerge queueMay 20, 2025
Merged via the queue intoPowerShell:main with commit367d952May 20, 2025
6 of 7 checks passed
@haodeonhaodeon deleted the fix/winPS-ClassBased branchMay 27, 2025 12:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@michaeltlombardimichaeltlombardimichaeltlombardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@haodeon@Gijsreyn@michaeltlombardi@SteveL-MSFT
[8]ページ先頭
©2009-2025 Movatter.jp