This PR addresses#791. While it is a small redesign, casting the value to a string makes logical sense. When users are exporting or getting values, they can capture the results and store them as a configuration document instead of having them returned as integers. This would match the schematics, even though that is not implementedfully.

Gijsreyn added6 commits

May 9, 2025 16:34

Add fix to return enum string values

3ca7481

Comment out changes

493949b

Wrong commit

2f93833

Add fix to return enum string values

a3dbc62

Comment out changes

4d6dd30

Wrong commit

64dfed9

Gijsreyn force-pushed thefix-enum-output branch from2f93833 to64dfed9Compare

May 10, 2025 13:20

Gijsreyn added2 commits

May 10, 2025 15:21

Merge branch 'fix-enum-output' ofhttps://github.com/Gijsreyn/operati…

39ffc1c

…on-methods into fix-enum-output

Fix test results

17331c9

Copy link

ContributorAuthor

Gijsreyn commentedMay 10, 2025

@mgreenegit I'm bothering Steve too much, so I thought of giving you a heads-up. Could you take a quick look at this one? It shouldn't be that big of a change.

Gijsreyn marked this pull request as ready for review

May 10, 2025 13:40

Gijsreyn added2 commits

May 10, 2025 15:50

Remove debug messages

9293de0

Merge branch 'main' into fix-enum-output

d8a82f3

SteveL-MSFT requested review frommichaeltlombardi,mgreenegit andtheJasonHelmick

May 17, 2025 05:26

michaeltlombardi reviewed

May 19, 2025

View reviewed changes

Copy link

Collaborator

michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor nits for readability and spacing characters.

powershell-adapter/Tests/powershellgroup.config.tests.ps1 OutdatedShow resolvedHide resolved

powershell-adapter/psDscAdapter/psDscAdapter.psm1 OutdatedShow resolvedHide resolved

Gijsreyn added2 commits

May 20, 2025 04:50

Styling

33db7f1

Break

cc98986

Copy link

ContributorAuthor

Gijsreyn commentedMay 20, 2025

Thanks@michaeltlombardi for the check. I thought there was a remark once to do it in the style Pester tests are written (OTBS). I switched the blocks inpsDscAdapter.psm1 to match that style.