NotificationsYou must be signed in to change notification settings
Fork45
Star349

fix: win_psDscAdapter targeted module cache refreshes#787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

SteveL-MSFT merged 4 commits intoPowerShell:mainfromhaodeon:fix/diff-get-all

May 19, 2025

Merged

fix: win_psDscAdapter targeted module cache refreshes#787

SteveL-MSFT merged 4 commits intoPowerShell:mainfromhaodeon:fix/diff-get-all

May 19, 2025

Conversation

Copy link

Contributor

haodeon commentedMay 7, 2025•
edited
Loading

PR Summary

Fixes#745 by ensuring a fullGet-DscResource refresh is triggered when$env:PSModulePath changes.

Also reorders the cache staleness checks to prioritize detectingPSModulePath differences before evaluating stale resource entries.

Fixes#807 by ensuring a full cache refresh is triggered when cache is cold. It now builds a list$namedModules which determines whether targeted module refresh occurs, using this list if it does.

PR Context

When$env:PSModulePath changes, the cache may be rebuilt incorrectly if$Module remains set. The module environment may have changed outside the scope defined by$Module, but the refresh will only consider the provided modules.

When a module is deleted, the stale entries check will detect the change and initiate a cache refresh, skipping the check for stale paths. If the removed module is not in$Module, the stale entries get captured in$existingDscResourceCacheEntries and remain in the refreshed cache.

A change inPSModulePath should result in a full cache refresh and take priority over stale resource entries.