- Notifications
You must be signed in to change notification settings - Fork45
Fix adapter configuration set which returnsresult
, but needs to beresources
#774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Tess Gauthier <tgauth@bu.edu>
tgauth approved these changesMay 1, 2025
Merged via the queue intoPowerShell:main with commitMay 1, 2025
66047e0
4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The problem is that using PS Adapter implicitly means the engine dynamically creates a new configuration that wraps the resource with appropriate adapter (PS7 or WinPS5.1). This gets run which works fine. However, a part of
set
also performs aget
to get thebefore_state
. Aget
returns the payload asresult
, however, the actualbefore_state
as defined in the configuration isresources
. So the fix is to address this situation wherebefore_state
needs to be retrieved at runtime and make it look like a correctset
response.