NotificationsYou must be signed in to change notification settings
Fork45
Star349

Add`equals()` function#770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

SteveL-MSFT merged 3 commits intoPowerShell:mainfromSteveL-MSFT:equals-function

Apr 30, 2025

Merged

Add`equals()` function#770

SteveL-MSFT merged 3 commits intoPowerShell:mainfromSteveL-MSFT:equals-function

Apr 30, 2025

Conversation

Copy link

Member

SteveL-MSFT commentedApr 28, 2025•
edited
Loading

PR Summary

Addequals() function needed for Bicep

Part of#767

Addequals() function

ca46f9b

SteveL-MSFT requested review fromandyleejordan andtgauth

April 28, 2025 23:22

SteveL-MSFT marked this pull request as ready for review

April 28, 2025 23:22

SteveL-MSFT added2 commits

April 28, 2025 16:33

remove array tests

2643a3f

fix test

56457ad

michaeltlombardi added the Doc-Impact label

Apr 29, 2025

tgauth reviewed

Apr 29, 2025

View reviewed changes

dsc_lib/src/functions/equals.rsShow resolvedHide resolved

tgauth approved these changes

Apr 30, 2025

View reviewed changes

SteveL-MSFT added this pull request to themerge queue

Apr 30, 2025

Merged via the queue intoPowerShell:main with commit04602e5

Apr 30, 2025

4 checks passed

SteveL-MSFT deleted the equals-function branch

April 30, 2025 21:51

andyleejordan approved these changes

Apr 30, 2025

View reviewed changes

Copy link

Member

andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok it's great, and worked, but now I know we also needif (ducks).

2025-04-30T21:58:36.246997Z  INFO dsc_lib::configure: 668: Set parameter 'colorMode' to '"dark"'2025-04-30T21:58:36.247609Z DEBUG dsc_lib::parser: 48: Parsing statement: [if(equals(parameters('colorMode'), 'light'), 1, 0)]2025-04-30T21:58:36.248239Z DEBUG dsc_lib::parser: 84: Parsing expression2025-04-30T21:58:36.248858Z DEBUG dsc_lib::parser::expressions: 43: Parsing function '{Node function (0, 1) - (0, 51)}'2025-04-30T21:58:36.249478Z DEBUG dsc_lib::parser::expressions: 43: Parsing function '{Node function (0, 4) - (0, 44)}'2025-04-30T21:58:36.250067Z DEBUG dsc_lib::parser::expressions: 43: Parsing function '{Node function (0, 11) - (0, 34)}'2025-04-30T21:58:36.250790Z DEBUG dsc_lib::parser::functions: 57: Function name: 'parameters'2025-04-30T21:58:36.253219Z DEBUG dsc_lib::parser::functions: 57: Function name: 'equals'2025-04-30T21:58:36.253851Z DEBUG dsc_lib::parser::functions: 57: Function name: 'if'2025-04-30T21:58:36.254457Z DEBUG dsc_lib::parser::functions: 75: Argument is an expression2025-04-30T21:58:36.255039Z DEBUG dsc_lib::parser::functions: 75: Argument is an expression2025-04-30T21:58:36.255623Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'String("colorMode")'2025-04-30T21:58:36.256278Z DEBUG dsc_lib::functions::parameters: 30: parameters function2025-04-30T21:58:36.256900Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'String("light")'2025-04-30T21:58:36.257484Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'Number(1)'2025-04-30T21:58:36.266986Z DEBUG dsc_lib::parser::functions: 80: Argument is a value: 'Number(0)'2025-04-30T21:58:36.267733Z ERROR dsc::subcommand: 370: Parameter input failure: Parser: Unknown function 'if'