Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for discovery extensions#760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SteveL-MSFT merged 12 commits intoPowerShell:mainfromSteveL-MSFT:discovery-extension
May 7, 2025

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFTSteveL-MSFT commentedApr 24, 2025
edited
Loading

PR Summary

  • Add new subcommand todsc to list extensions:dsc extension list
  • Add new ExtensionManifest which is similar but differs from ResourceManifest. Onlydiscover capability currently supported.
  • Enhance existing discovery code to handle both resources and extensions. This includes pre-discoverying extensions when discovering resources since an extension may participate. This included a new enum to handle returning either resources or extensions.
  • Write extensions as table when used interactively
  • Rename existing functions to generalize for both resource and extension use, this also required making some private functions public

The output from a discovery extension must match:

{"manifestPath":"<absolute path>" }

PR Context

Fix#681

Gijsreyn reacted with eyes emoji
@SteveL-MSFTSteveL-MSFTforce-pushed thediscovery-extension branch 3 times, most recently from83825d3 toa9277d8CompareApril 24, 2025 20:20
@SteveL-MSFTSteveL-MSFTforce-pushed thediscovery-extension branch 2 times, most recently from87a764c to27e0ae6CompareMay 1, 2025 22:26
@michaeltlombardi
Copy link
Collaborator

Currently, the implementation requires returning the absolute path to aresource manifest - but I
can already see use cases for discoveringextension manifests. For example, I might have
installed an extension from WinGet, and need to discover that, too.

Right now, it expects JSON like this:

{"resourceManifestPath":"/foo/bar/baz.dsc.resource.json"}

But we could have it return this, and parse the last segment of the path to determine kind:

{"absoluteManifestPath":"/foo/bar/baz.dsc.extension.json"}

Or require it return eitherresourceManifestPath orextensionManifestPath.

If we support extensions discovering extensions, we would need to recursively handle extension
discovery.

@SteveL-MSFT
Copy link
MemberAuthor

I think we can defer extension discovery til when we need it

michaeltlombardi reacted with thumbs up emoji

@SteveL-MSFT
Copy link
MemberAuthor

Renamed fromresourceManifestPath to justmanifestPath to reuse extensions in the future. I don't think we need to prefix withabsolute

michaeltlombardi reacted with thumbs up emoji

@SteveL-MSFTSteveL-MSFT added this pull request to themerge queueMay 7, 2025
Merged via the queue intoPowerShell:main with commitf1be730May 7, 2025
4 checks passed
@SteveL-MSFTSteveL-MSFT deleted the discovery-extension branchMay 7, 2025 00:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@michaeltlombardimichaeltlombardimichaeltlombardi approved these changes

@tgauthtgauthtgauth approved these changes

@adityapatwardhanadityapatwardhanAwaiting requested review from adityapatwardhan

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discovery extension type resource
3 participants
@SteveL-MSFT@michaeltlombardi@tgauth

[8]ページ先頭

©2009-2025 Movatter.jp