- Notifications
You must be signed in to change notification settings - Fork45
FixAssertion
resource to fail when test fails#736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
tgauth approved these changesApr 4, 2025
Merged via the queue intoPowerShell:main with commitApr 4, 2025
a1cd9ec
4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
A previous PR that cleaned up the output of
Assertion
to fit withget
andset
caused the assertion to never actually fail, just return results in the desired format.The change here is to add a new hidden switch
--as-assert
so thatdsc
knows it's running asAssertion
. Then when this is used it checks each test result and if any are NOT in desired state, it returns an error that the assertion failed. Many of the changes is just to pass this parameter to the necessary functions. A helper function is used to potentially recursively look at all theinDesiredState
properties.PR Context
Fix#731