Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP] WMI adapter improvements#520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Gijsreyn wants to merge11 commits intoPowerShell:main
base:main
Choose a base branch
Loading
fromGijsreyn:wmi-adapter

Conversation

Gijsreyn
Copy link
Contributor

PR Summary

Starting to address#475 and newwmiAdapter module included

PR Context

@GijsreynGijsreyn changed the titleWMI adapter improvements[WIP] WMI adapter improvementsAug 15, 2024
@Gijsreyn
Copy link
ContributorAuthor

@anmenaga Hey Andrew, I definitely didn’t want to step on your toes, but while I was testing the WMI adapter, I thought I'd contribute a bit. Would you mind taking a look at my initial commit when you have a moment?

@Gijsreyn
Copy link
ContributorAuthor

@michaeltlombardi Hey Mikey, I could not attend the DSC community call last week so was unable to ask the question here. In the wmi.resource.ps1 file, resources are listed in a[pscustomobject] matching thedsc-resource schema definition. When developing theset operation capability, I stumbled on the fact, that there is not a key property that allows setting the CimClassMethods

I don't know if this is something that can be changed. In the current PR, I coined to usemethodDetails ormethods. I recognize other adapters "might" require to implement it or set it as null / array value.

If it's something to be discussed into a discussion, then that's also fine.

@SteveL-MSFT
Copy link
Member

@Gijsreyn I appreciate you taking the time to help improve the WMI adapter, however, I think it would be more productive for us if you can make smaller targeted changes making it easier to review and get merged in rather than one large PR that will take a lot longer to review and iterate.

@Gijsreyn
Copy link
ContributorAuthor

@SteveL-MSFT Thanks for the response. I get the point, thought of picking most of the content what was already available from thepowershell-adapter.

@SteveL-MSFT
Copy link
Member

Since this is a WIP, converting to draft PR

@SteveL-MSFTSteveL-MSFT marked this pull request as draftJune 5, 2025 18:55
@GijsreynGijsreyn mentioned this pull requestJun 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Gijsreyn@SteveL-MSFT

[8]ページ先頭

©2009-2025 Movatter.jp