Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ports extensions from Nebula#9059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Atermonera wants to merge2 commits intoPolarisSS13:master
base:master
Choose a base branch
Loading
fromAtermonera:extensible_extensions_extending

Conversation

@Atermonera
Copy link
Contributor

First pass at porting extensions, as on tin. Provided without verification but with warranty.

  • Grabs what appears to be the basic underlying things.
  • Updates hand labeler to use the label extension, tries to tie it into other places but this is probably incomplete and will most likely require further effort on my part.
  • Swipes, but does not tick, some extensions that I'm particular interested in trying to use.
    • /eye and /on_click are unticked.
  • Makes extensions athing that exists, such that the lack of extensions outright is no longer a non-starter for a number of other potential ports.

@AtermoneraAtermonera added the Port[PR] This is code or assets from another codebase. labelMar 14, 2023
if(length(A.name)+ length(label)>64)
to_chat(user,SPAN_WARNING("\The[src]'s label too big."))
return
if(istype(A,/mob/living/silicon/robot/platform))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This block is separate to the label system generally, it renames the mob.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Disregard, just saw the proc.

@MistakeNot4892
Copy link
Contributor

MistakeNot4892 commentedMar 14, 2023
edited
Loading

I'm not sure if this is a good idea. Components and extensions have a ton of overlap in functionality even if the DSC pattern bars you from using components from extension-like functions. Having both systems in parallel feels like a complexity and maintenance issue.

Snips unused code
@Atermonera
Copy link
ContributorAuthor

I agree that the two-implementation solution is messy (See: nanoui v. tgui, among probably numerous other examples), but there actually isn't that much that uses components right now.
I much more often see shiny things that wecould have, but for lacking extensions, than I do shiny things that we'regetting because we have components.

@SpookertonSpookerton added the Stale[PR] This requires additional work and appears abandoned. labelAug 23, 2023
@SpookertonSpookerton marked this pull request as draftAugust 23, 2023 15:25
@Spookerton
Copy link
Contributor

I would want this to come with a commitment to transition existing component use to extensions, which I think defeats the "I much more often see shiny things that we could have" sentiment which, I assume, carries the caveat of still wanting the shiny things from components without the effort of translation. I agree with MistakeNot4892 - both is a recipe for overhead, interoperability issues, and dev headaches.

I'm biased in favor of extensions because they're what I use already elsewhere. I've found DSC a tad less approachable, largely due to the rote use of its own signals system creating a lot of async funnies and signal comprehension instead of direct calls.

Buuuut it is what currently exists. Translating extensions to it is just as possible.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@MistakeNot4892MistakeNot4892MistakeNot4892 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Port[PR] This is code or assets from another codebase.Stale[PR] This requires additional work and appears abandoned.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Atermonera@MistakeNot4892@Spookerton

[8]ページ先頭

©2009-2025 Movatter.jp