NotificationsYou must be signed in to change notification settings
Fork587
Star2.1k

Use PerlLIO_dup_cloexec in Perl_dirp_dup to set O_CLOEXEC#23361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Leont merged 1 commit intobleadfromleont/fdopendir-dup

Jun 9, 2025

Merged

Use PerlLIO_dup_cloexec in Perl_dirp_dup to set O_CLOEXEC#23361

Leont merged 1 commit intobleadfromleont/fdopendir-dup

Jun 9, 2025

Conversation

Copy link

Contributor

Leont commentedJun 9, 2025

dup doesn't mark the new descriptor as close-on-exec, which can lead to a descriptor leaking to the new process.

Use PerlLIO_dup_cloexec in Perl_dirp_dup to set O_CLOEXEC

3de3753

dup doesn't mark the new descriptor as close-on-exec, which can lead toa descriptor leaking to the new process.

khwilliamson approved these changes

Jun 9, 2025

View reviewed changes

ilmari approved these changes

Jun 9, 2025

View reviewed changes

Leont merged commitd6f09a8 intoblead

Jun 9, 2025

68 checks passed

Copy link

Contributor

ap commentedJun 12, 2025

@steve-m-hay This should be applied to maint-5.38 and maint-5.40 before the security release. (Aside from this we also need a perldelta entry before they can ship.)

Copy link

Contributor

steve-m-hay commentedJun 12, 2025

@steve-m-hay This should be applied to maint-5.38 and maint-5.40 before the security release. (Aside from this we also need a perldelta entry before they can ship.)

Cherry-picked as required.