- Notifications
You must be signed in to change notification settings - Fork587
cygwin.c: fix several silly/terrible C errors#22724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Errors fixed:Not detected by the compiler, but the preprocessor version checks onlylooked at `CYGWIN_VERSION_API_MINOR`, ignoring`CYGWIN_VERSION_API_MAJOR`. cygwin.c: In function 'utf8_to_wide_extra_len': cygwin.c:187:18: warning: initialization of 'size_t' {aka 'long unsigned int'} from 'size_t *' {aka 'long unsigned int *'} makes integer from pointer without a cast [-Wint-conversion] 187 | Size_t len = strlen(buf) + extra_len + 1; | ^~~~~~`extra_len` was declared as a pointer, but used as an integer. I don'tsee how this could have ever worked. cygwin.c: In function 'S_convert_path_common': cygwin.c:339:38: warning: 'realloc' called on unallocated object 'wconverted' [-Wfree-nonheap-object] 339 | wconverted = (wchar_t *) realloc(&wconverted, newlen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cygwin.c:357:39: warning: 'realloc' called on unallocated object 'converted_path' [-Wfree-nonheap-object] 357 | converted_path = (char *) realloc(&converted_path, newlen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Again, I don't see how this could have ever worked. We're passing theaddress of a local (stack) variable to `realloc` (instead of the valueof the variable). cygwin.c: In function 'wide_to_utf8': cygwin.c:173:32: warning: pointer targets in passing argument 3 of 'Perl_utf16_to_utf8_base' differ in signedness [-Wpointer-sign] 173 | utf16_to_utf8((U8 *) wsrc, buf, wlen, &blen); | ^~~ | | | char *The argument is declared as `U8 *`, so this is mostly harmless, but acast silences the warning anyway. cygwin.c: In function 'utf8_to_wide_extra_len': cygwin.c:194:19: warning: passing argument 2 of 'Perl_utf8_to_utf16_base' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 194 | utf8_to_utf16(buf, (U8 *) wsrc, len, &wlen); | ^~~This is arguably a bug in `utf8_to_utf16`, which doesn't declare itsinput argument as pointer-to-const. But it's also a `char *` vs `U8 *`type mismatch, so a cast silences both issues. cygwin.c: In function 'S_convert_path_common': cygwin.c:292:22: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 292 | char *name = (direction == to_posix) | ^This is a missing `const` in the declaration of a variable that pointsto string literals.
tonycoz approved these changesNov 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors fixed:
Not detected by the compiler, but the preprocessor version checks only looked at
CYGWIN_VERSION_API_MINOR
, ignoringCYGWIN_VERSION_API_MAJOR
.extra_len
was declared as a pointer, but used as an integer. I don't see how this could have ever worked.Again, I don't see how this could have ever worked. We're passing the address of a local (stack) variable to
realloc
(instead of the value of the variable).The argument is declared as
U8 *
, so this is mostly harmless, but a cast silences the warning anyway.This is arguably a bug in
utf8_to_utf16
, which doesn't declare its input argument as pointer-to-const. But it's also achar *
vsU8 *
type mismatch, so a cast silences both issues.This is a missing
const
in the declaration of a variable that points to string literals.