Commitd2bdba3

committed

S_uiv_2buf: code quality improvements suggested in GH#22927

1 parent0e374ed commitd2bdba3Copy full SHA for d2bdba3

File tree

+11

-10

lines changed

+11

-10

lines changed

Lines changed: 11 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -1044,7 +1044,6 @@ S_uiv_2buf(char const buf, const IV iv, UV uv, const int is_uv, char *const pe`
`1044`	`1044`	`{`
`1045`	`1045`	`char*ptr=buf+TYPE_CHARS(UV);`
`1046`	`1046`	`char*constebuf=ptr;`
`1047`		`-intsign;`
`1048`	`1047`	`U16word_ptr,word_table;`
`1049`	`1048`
`1050`	`1049`	`PERL_ARGS_ASSERT_UIV_2BUF;`
`@@ -1055,15 +1054,17 @@ S_uiv_2buf(char const buf, const IV iv, UV uv, const int is_uv, char *const pe`
`1055`	`1054`	`word_ptr= (U16*)ptr;`
`1056`	`1055`	`word_table= (U16*)Perl_int2str_table.arr;`
`1057`	`1056`
`1058`		`-if (UNLIKELY(is_uv))`
`1059`		`-sign=0;`
`1060`		`-elseif (iv >=0) {`
`1061`		`-uv=iv;`
`1062`		`-sign=0;`
`1063`		`- }else {`
`1064`		`-/* Using 0- here to silence bogus warning from MS VC */`
`1065`		`-uv= (UV) (0- (UV)iv);`
`1066`		`-sign=1;`
	`1057`	`+boolsign= false;`
	`1058`	`+if (LIKELY(!is_uv)) {`
	`1059`	`+if (iv >=0) {`
	`1060`	`+uv=iv;`
	`1061`	`+ }else {`
	`1062`	`+/* This is NEGATE_2UV(iv), which can be found in handy.h. */`
	`1063`	`+/* sv_inline.h does not include handy.h because the latter`
	`1064`	`+ * would then get included twice into .c files. */`
	`1065`	`+uv= (ASSUME((iv)<0), (UV)-((iv)+1)+1U);`
	`1066`	`+sign=1;`
	`1067`	`+ }`
`1067`	`1068`	`}`
`1068`	`1069`
`1069`	`1070`	`while (uv>99) {`

Comments

(0)