- Notifications
You must be signed in to change notification settings - Fork1
Add nanopore flag to assemblies view#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
2bfc8f3 intomainUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR refactors the assemblies browse view to replace path columns with a computed boolean flag indicating nanopore data availability. The change improves the UI by removing lengthy path strings from the table view while maintaining access to full details in the assembly detail pages.
Key Changes:
- Modified the
/api/assembliesendpoint to explicitly select fields and compute ananoporeboolean flag based on the presence ofnanopore_path - Updated the assemblies table to display "Nanopore" column instead of "Nanopore Path" and removed "Sunbeam Output Path" column
- Path fields remain accessible in detail views (
show_assembly.htmlandshow_isolate.html)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/app.py | Modified/api/assemblies endpoint to use explicit field selection with computednanopore boolean flag instead of returning all Assembly fields |
| app/templates/browse_assemblies.html | Updated table headers and column definitions to usenanopore boolean instead ofnanopore_path and removedsunbeam_output_path column |
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Summary
Testing
Codex Task