Commitfc8e5af

vasily-kirichenko

authored and

KevinRansom

committed

Fix wrong FSX colorization when #r directives change (dotnet#2521)

* add logging* use TryGetOptionsForDocumentOrProject instead of TryGetOptionsForEditingDocumentOrProject in Classification Service to avoid passing stale options to FCS* Revert "add logging"This reverts commit72b8421.

1 parentd9077c7 commitfc8e5afCopy full SHA for fc8e5af

File tree

1 file changed

-1

lines changed

vsintegration/src/FSharp.Editor/Classification
- ColorizationService.fs

1 file changed

-1

lines changed

`‎vsintegration/src/FSharp.Editor/Classification/ColorizationService.fs‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ type internal FSharpColorizationService`
`35`	`35`
`36`	`36`	`memberthis.AddSemanticClassificationsAsync(document:Document,textSpan:TextSpan,result:List<ClassifiedSpan>,cancellationToken:CancellationToken)=`
`37`	`37`	`asyncMaybe{`
`38`		`-let!options= projectInfoManager.TryGetOptionsForEditingDocumentOrProject(document)`
	`38`	`+let!options= projectInfoManager.TryGetOptionsForDocumentOrProject(document)`
`39`	`39`	`let!sourceText= document.GetTextAsync(cancellationToken)`
`40`	`40`	`let!_,_,checkResults= checkerProvider.Checker.ParseAndCheckDocument(document, options, sourceText= sourceText, allowStaleResults=false)`
`41`	`41`	// it's crucial to not return duplicated or overlapping `ClassifiedSpan`s because Find Usages service crashes.

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfc8e5af

File tree

1 file changed

1 file changed

`‎vsintegration/src/FSharp.Editor/Classification/ColorizationService.fs‎`

0 commit comments