Commitf0e945c

authored and

committed

Compute indexed List only once (dotnet#2269)

1 parent44514f3 commitf0e945cCopy full SHA for f0e945c

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4793,8 +4793,9 @@ and CrackStaticConstantArgs cenv env tpenv (staticParameters: Tainted<ProvidedPa`
`4793`	`4793`	`if not otherArgs.IsEmpty then`
`4794`	`4794`	`error (Error(FSComp.SR.etBadUnnamedStaticArgs(),m))`
`4795`	`4795`
	`4796`	`+ let indexedStaticParameters = staticParameters \|> Array.toList \|> List.indexed`
`4796`	`4797`	`for (n,_) in namedArgs do`
`4797`		`- matchstaticParameters \|> Array.toList \|> List.mapi (fun j x -> (j,x)) \|> List.filter (fun (j,sp) -> j >= unnamedArgs.Length && n.idText = sp.PUntaint((fun sp -> sp.Name), m)) with`
	`4798`	`+ matchindexedStaticParameters \|> List.filter (fun (j,sp) -> j >= unnamedArgs.Length && n.idText = sp.PUntaint((fun sp -> sp.Name), m)) with`
`4798`	`4799`	`\| [] ->`
`4799`	`4800`	`if staticParameters \|> Array.exists (fun sp -> n.idText = sp.PUntaint((fun sp -> sp.Name), n.idRange)) then`
`4800`	`4801`	`error (Error(FSComp.SR.etStaticParameterAlreadyHasValue n.idText,n.idRange))`

Comments

(0)