Commite861d98

authored

fix memory capture by TcSymbolUses (dotnet#2377)

This fixes memory capture by the retained TcSymbolUses structure, which was unnecessarily capturing the NameResolutionEnv objects for each symbol use

1 parent3bf3960 commite861d98Copy full SHA for e861d98

File tree

+10

-5

lines changed

+10

-5

lines changed

Lines changed: 10 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1391,15 +1391,20 @@ type TcResolutions`
`1391`	`1391`
`1392`	`1392`	`/// Represents container for all name resolutions that were met so far when typechecking some particular file`
`1393`	`1393`	`typeTcSymbolUses(g, capturedNameResolutions:ResizeArray<CapturedNameResolution>,formatSpecifierLocations: range[])=`
	`1394`	`+`
	`1395`	`+// Make sure we only capture the information we really need to report symbol uses`
	`1396`	`+letcnrs=[\|for cnrin capturedNameResolutions-> cnr.Item, cnr.ItemOccurence, cnr.DisplayEnv, cnr.Range\|]`
	`1397`	`+letcapturedNameResolutions=()`
	`1398`	`+do ignore capturedNameResolutions// don't capture this!`
`1394`	`1399`
`1395`	`1400`	`memberthis.GetUsesOfSymbol(item)=`
`1396`		`-[\|forcnrincapturedNameResolutionsdo`
`1397`		`-if protectAssemblyExplorationfalse(fun()-> ItemsAreEffectivelyEqual g itemcnr.Item)then`
`1398`		`-yieldcnr.ItemOccurence, cnr.DisplayEnv, cnr.Range\|]`
	`1401`	`+[\|for(cnrItem,occ,denv,m)incnrsdo`
	`1402`	`+if protectAssemblyExplorationfalse(fun()-> ItemsAreEffectivelyEqual g itemcnrItem)then`
	`1403`	`+yieldocc, denv, m\|]`
`1399`	`1404`
`1400`	`1405`	`memberthis.GetAllUsesOfSymbols()=`
`1401`		`-[\|forcnrincapturedNameResolutionsdo`
`1402`		`-yield(cnr.Item, cnr.ItemOccurence, cnr.DisplayEnv, cnr.Range)\|]`
	`1406`	`+[\|for(cnrItem,occ,denv,m)incnrsdo`
	`1407`	`+yield(cnrItem, occ, denv, m)\|]`
`1403`	`1408`
`1404`	`1409`	`memberthis.GetFormatSpecifierLocations()= formatSpecifierLocations`
`1405`	`1410`

Comments

(0)