Commite42cea2

forki

authored and

KevinRansom

committed

Use lazy evaluation for useMethodImpl (dotnet#5728)

1 parent2e4e60f commite42cea2Copy full SHA for e42cea2

File tree

1 file changed

+22

-15

lines changed

src/fsharp
- IlxGen.fs

1 file changed

+22

-15

lines changed

`‎src/fsharp/IlxGen.fs‎`

Lines changed: 22 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -5121,25 +5121,32 @@ and ComputeFlagFixupsForMemberBinding cenv (v:Val,memberInfo:ValMemberInfo) =`
`5121`	`5121`	`letotcref= tcrefOfAppTy cenv.g oty`
`5122`	`5122`	`lettcref= v.MemberApparentEntity`
`5123`	`5123`
`5124`		`-letuseMethodImpl=`
`5125`		`-// REVIEW: it would be good to get rid of this special casing of Compare and GetHashCode during code generation`
`5126`		`-letisCompare=`
`5127`		`-(Option.isSome tcref.GeneratedCompareToValues&& typeEquiv cenv.g oty cenv.g.mk_IComparable_ty)\|\|`
`5128`		`-(Option.isSome tcref.GeneratedCompareToValues&& tyconRefEq cenv.g cenv.g.system_GenericIComparable_tcref otcref)`
`5129`		`-`
`5130`		`-letisGenericEquals=`
`5131`		`-(Option.isSome tcref.GeneratedHashAndEqualsWithComparerValues&& tyconRefEq cenv.g cenv.g.system_GenericIEquatable_tcref otcref)`
`5132`		`-`
`5133`		`-letisStructural=`
`5134`		`-(Option.isSome tcref.GeneratedCompareToWithComparerValues&& typeEquiv cenv.g oty cenv.g.mk_IStructuralComparable_ty)\|\|`
`5135`		`-(Option.isSome tcref.GeneratedHashAndEqualsWithComparerValues&& typeEquiv cenv.g oty cenv.g.mk_IStructuralEquatable_ty)`
`5136`		`- isInterfaceTy cenv.g oty&&not isCompare&&not isStructural&&not isGenericEquals`
	`5124`	`+letuseMethodImpl=`
	`5125`	`+// REVIEW: it would be good to get rid of this special casing of Compare and GetHashCode during code generation`
	`5126`	`+ isInterfaceTy cenv.g oty&&`
	`5127`	`+(letisCompare=`
	`5128`	`+ Option.isSome tcref.GeneratedCompareToValues&&`
	`5129`	`+(typeEquiv cenv.g oty cenv.g.mk_IComparable_ty\|\|`
	`5130`	`+ tyconRefEq cenv.g cenv.g.system_GenericIComparable_tcref otcref)`
	`5131`	`+`
	`5132`	`+not isCompare)&&`
	`5133`	`+`
	`5134`	`+(letisGenericEquals=`
	`5135`	`+ Option.isSome tcref.GeneratedHashAndEqualsWithComparerValues&& tyconRefEq cenv.g cenv.g.system_GenericIEquatable_tcref otcref`
	`5136`	`+`
	`5137`	`+not isGenericEquals)&&`
	`5138`	`+(letisStructural=`
	`5139`	`+(Option.isSome tcref.GeneratedCompareToWithComparerValues&& typeEquiv cenv.g oty cenv.g.mk_IStructuralComparable_ty)\|\|`
	`5140`	`+(Option.isSome tcref.GeneratedHashAndEqualsWithComparerValues&& typeEquiv cenv.g oty cenv.g.mk_IStructuralEquatable_ty)`
`5137`	`5141`
	`5142`	`+not isStructural)`
`5138`	`5143`
`5139`	`5144`	`letnameOfOverridingMethod= GenNameOfOverridingMethod cenv(useMethodImpl,slotsig)`
`5140`	`5145`
`5141`		`-(if useMethodImplthen fixupMethodImplFlags>> renameMethodDef nameOfOverridingMethod`
`5142`		`-else fixupVirtualSlotFlags>> renameMethodDef nameOfOverridingMethod))`
	`5146`	`+if useMethodImplthen`
	`5147`	`+ fixupMethodImplFlags>> renameMethodDef nameOfOverridingMethod`
	`5148`	`+else`
	`5149`	`+ fixupVirtualSlotFlags>> renameMethodDef nameOfOverridingMethod)`
`5143`	`5150`
`5144`	`5151`	`andComputeMethodImplAttribs cenv(_v:Val)attrs=`
`5145`	`5152`	`letimplflags=`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite42cea2

File tree

1 file changed

1 file changed

`‎src/fsharp/IlxGen.fs‎`

0 commit comments