Commitda5d0f6

authored and

committed

One lookup in nenv.eFieldLabels should be enough (dotnet#4469)

1 parent3fc5e6d commitda5d0f6Copy full SHA for da5d0f6

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -3169,16 +3169,16 @@ let private ResolveExprDotLongIdent (ncenv:NameResolver) m ad nenv typ lid findF`
`3169`	`3169`	`if isAppTy ncenv.g typthen`
`3170`	`3170`	`NoResultsOrUsefulErrors`
`3171`	`3171`	`else`
`3172`		`-match lidwith`
	`3172`	`+match lidwith`
`3173`	`3173`	`// A unique record label access, e.g expr.field`
`3174`		`-\| id::restwhen nenv.eFieldLabels.ContainsKey(id.idText)->`
`3175`		`-match nenv.eFieldLabels.[id.idText]with`
`3176`		`-\|[]-> NoResultsOrUsefulErrors`
`3177`		`-\| rfref::_->`
	`3174`	`+\| id::rest->`
	`3175`	`+match Map.tryFind id.idText nenv.eFieldLabelswith`
	`3176`	`+\| Some(rfref::_)->`
`3178`	`3177`	`// NOTE (instantiationGenerator cleanup): we need to freshen here because we don't know the type.`
`3179`	`3178`	`// But perhaps the caller should freshen??`
`3180`	`3179`	`letitem= FreshenRecdFieldRef ncenv m rfref`
`3181`	`3180`	`OneSuccess(ResolutionInfo.Empty,item,rest)`
	`3181`	`+\|_-> NoResultsOrUsefulErrors`
`3182`	`3182`	`\|_-> NoResultsOrUsefulErrors`
`3183`	`3183`
`3184`	`3184`	`letsearch= dotFieldIdSearch`

Comments

(0)