Commitbc7af5a

authored and

committed

Turn off KeywordCompletionProvider (dotnet#2441)

* KeywordCompletionProvider does not show operators* turn off KeywordCompletionProvider

1 parent4c41b73 commitbc7af5aCopy full SHA for bc7af5a

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,10 @@ type internal FSharpCompletionService`
`30`	`30`
`31`	`31`	`letbuiltInProviders=`
`32`	`32`	`ImmutableArray.Create<CompletionProvider>(`
`33`		`- FSharpCompletionProvider(workspace, serviceProvider, checkerProvider, projectInfoManager),`
`34`		`- FSharpKeywordCompletionProvider(workspace, projectInfoManager))`
	`33`	`+ FSharpCompletionProvider(workspace, serviceProvider, checkerProvider, projectInfoManager)`
	`34`	`+// we've turned off keyword completion because it does not filter suggestion depending on context.`
	`35`	`+// FSharpKeywordCompletionProvider(workspace, projectInfoManager)`
	`36`	`+)`
`35`	`37`
`36`	`38`	`letcompletionRules=`
`37`	`39`	`CompletionRules.Default`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,8 @@ type internal FSharpKeywordCompletionProvider`
`28`	`28`
`29`	`29`	`letcompletionItems=`
`30`	`30`	`Lexhelp.Keywords.keywordsWithDescription`
`31`		`-\|> List.map(fun(keyword,description)->`
	`31`	`+\|> List.filter(fun(keyword,_)->not(PrettyNaming.IsOperatorName keyword))`
	`32`	`+\|> List.map(fun(keyword,description)->`
`32`	`33`	`CommonCompletionItem.Create(keyword, Nullable(Glyph.Keyword)).AddProperty("description", description))`
`33`	`34`
`34`	`35`	`static memberShouldTriggerCompletionAux(sourceText:SourceText,caretPosition:int,trigger:CompletionTriggerKind,getInfo:(unit-> DocumentId* string* string list))=`

Comments

(0)