Commitb946161

vasily-kirichenko

authored and

KevinRansom

committed

fixed: XmlDocReader constructor raises exception in case of malformed XML Doc, which causes no Quick Info at all (dotnet#2507)

1 parentfd3752d commitb946161Copy full SHA for b946161

File tree

1 file changed

+12

-8

lines changed

vsintegration/src/FSharp.LanguageService
- XmlDocumentation.fs

1 file changed

+12

-8

lines changed

`‎vsintegration/src/FSharp.LanguageService/XmlDocumentation.fs‎`

Lines changed: 12 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -153,15 +153,18 @@ module internal XmlDocumentation =`
`153`	`153`	`collector.Add(Literals.dot)`
`154`	`154`	`collector.Add(tagClass parts.[parts.Length-1])`
`155`	`155`
`156`		`-typeXmlDocReader(s: string)=`
`157`		`-letdoc= XElement.Parse(ProcessXml(s))`
	`156`	`+typeXmlDocReaderprivate(doc: XElement)=`
	`157`	`+`
`158`	`158`	`lettryFindParameter name=`
`159`	`159`	`doc.Descendants(XName.op_Implicit"param")`
`160`	`160`	`\|> Seq.tryFind(fun el->`
`161`	`161`	`match el.Attribute(XName.op_Implicit"name")with`
`162`	`162`	`\|null->false`
`163`	`163`	`\| attr-> attr.Value= name)`
`164`	`164`
	`165`	`+static memberTryCreate(xml:string)=`
	`166`	`+try Some(XmlDocReader(XElement.Parse(ProcessXml xml)))with_-> None`
	`167`	`+`
`165`	`168`	`member__.CollectSummary(collector:ITaggedTextCollector)=`
`166`	`169`	`match Seq.tryHead(doc.Descendants(XName.op_Implicit"summary"))with`
`167`	`170`	`\| None->()`
`@@ -279,12 +282,13 @@ module internal XmlDocumentation =`
`279`	`282`
`280`	`283`	`interface IDocumentationBuilderwith`
`281`	`284`	`/// Append the given processed XML formatted into the string builder`
`282`		`-overridethis.AppendDocumentationFromProcessedXML(appendTo,processedXml,showExceptions,showParameters,paramName)=`
`283`		`-letxmlDocReader= XmlDocReader(processedXml)`
`284`		`-if paramName.IsSomethen`
`285`		`- xmlDocReader.CollectParameter(appendTo, paramName.Value)`
`286`		`-else`
`287`		`- AppendMemberData(appendTo, xmlDocReader, showExceptions,showParameters)`
	`285`	`+overridethis.AppendDocumentationFromProcessedXML(appendTo,processedXml,showExceptions,showParameters,paramName)=`
	`286`	`+match XmlDocReader.TryCreate processedXmlwith`
	`287`	`+\| Some xmlDocReader->`
	`288`	`+match paramNamewith`
	`289`	`+\| Some paramName-> xmlDocReader.CollectParameter(appendTo, paramName)`
	`290`	`+\| None-> AppendMemberData(appendTo, xmlDocReader, showExceptions,showParameters)`
	`291`	`+\| None->()`
`288`	`292`
`289`	`293`	`/// Append Xml documentation contents into the StringBuilder`
`290`	`294`	`overridethis.AppendDocumentation`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb946161

File tree

1 file changed

1 file changed

`‎vsintegration/src/FSharp.LanguageService/XmlDocumentation.fs‎`

0 commit comments