Commitab0d7a7

dsyme

authored and

KevinRansom

committed

don't keep tcEnvAtEnd for background states unless keepAllBackgroundResolutions=true (dotnet#2388)

1 parent8e66eca commitab0d7a7Copy full SHA for ab0d7a7

File tree

1 file changed

-3

lines changed

src/fsharp/vs
- IncrementalBuild.fs

1 file changed

-3

lines changed

`‎src/fsharp/vs/IncrementalBuild.fs‎`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1427,8 +1427,8 @@ type IncrementalBuilder(frameworkTcImportsCache: FrameworkImportsCache, tcConfig`
`1427`	`1427`	`errorLogger.Warning(e)`
`1428`	`1428`	`frameworkTcImports`
`1429`	`1429`
`1430`		`-lettcEnvAtEndOfFile= GetInitialTcEnv(assemblyName, rangeStartup, tcConfig, tcImports, tcGlobals)`
`1431`		`-lettcState= GetInitialTcState(rangeStartup, assemblyName, tcConfig, tcGlobals, tcImports, niceNameGen,tcEnvAtEndOfFile)`
	`1430`	`+lettcInitial= GetInitialTcEnv(assemblyName, rangeStartup, tcConfig, tcImports, tcGlobals)`
	`1431`	`+lettcState= GetInitialTcState(rangeStartup, assemblyName, tcConfig, tcGlobals, tcImports, niceNameGen,tcInitial)`
`1432`	`1432`	`letloadClosureErrors=`
`1433`	`1433`	`[match loadClosureOptwith`
`1434`	`1434`	`\| None->()`
`@@ -1442,7 +1442,7 @@ type IncrementalBuilder(frameworkTcImportsCache: FrameworkImportsCache, tcConfig`
`1442`	`1442`	`tcImports=tcImports`
`1443`	`1443`	`tcState=tcState`
`1444`	`1444`	`tcConfig=tcConfig`
`1445`		`- tcEnvAtEndOfFile=tcEnvAtEndOfFile`
	`1445`	`+ tcEnvAtEndOfFile=tcInitial`
`1446`	`1446`	`tcResolutions=[]`
`1447`	`1447`	`tcSymbolUses=[]`
`1448`	`1448`	`topAttribs=None`
`@@ -1479,6 +1479,7 @@ type IncrementalBuilder(frameworkTcImportsCache: FrameworkImportsCache, tcConfig`
`1479`	`1479`	`/// Only keep the typed interface files when doing a "full" build for fsc.exe, otherwise just throw them away`
`1480`	`1480`	`lettypedImplFiles=if keepAssemblyContentsthen typedImplFileselse[]`
`1481`	`1481`	`lettcResolutions=if keepAllBackgroundResolutionsthen sink.GetResolutions()else TcResolutions.Empty`
	`1482`	`+lettcEnvAtEndOfFile=(if keepAllBackgroundResolutionsthen tcEnvAtEndOfFileelse tcState.TcEnvFromImpls)`
`1482`	`1483`	`lettcSymbolUses= sink.GetSymbolUses()`
`1483`	`1484`	`fileChecked.Trigger(filename)`
`1484`	`1485`	`return{tcAccwith tcState=tcState`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitab0d7a7

File tree

1 file changed

1 file changed

`‎src/fsharp/vs/IncrementalBuild.fs‎`

0 commit comments