Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commita75cb38

Browse files
committed
Update w/ code review feedback
1 parentd2e1591 commita75cb38

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

‎vsintegration/src/vs/FsPkgs/FSharp.VS.FSI/fsiPackageHooks.fs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,9 @@ module internal Hooks =
7575
letOnMLSend(this:Package)(action:FsiEditorSendAction)(sender:obj)(e:EventArgs)=
7676
withFSIToolWindow this(fun window->
7777
match actionwith
78-
| FsiEditorSendAction.ExecuteSelection-> window.MLSendSelection(sender, e)
79-
| FsiEditorSendAction.ExecuteLine-> window.MLSendLine(sender, e)
80-
| FsiEditorSendAction.DebugSelection-> window.MLDebugSelection(sender, e)
81-
|_-> ignore()// appease 'missing match case' warning
78+
| ExecuteSelection-> window.MLSendSelection(sender, e)
79+
| ExecuteLine-> window.MLSendLine(sender, e)
80+
| DebugSelection-> window.MLDebugSelection(sender, e)
8281
)
8382

8483
letAddReferencesToFSI(this:Package)references=

‎vsintegration/src/vs/FsPkgs/FSharp.VS.FSI/fsiSessionToolWindow.fs‎

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,15 @@ module internal Locals =
7474
openUtil
7575
openLocals
7676

77-
// consumed by C#, so enum types used instead of unions
7877
typeinternalFsiDebuggerState=
79-
| NotRunning=0
80-
| AttachedToFSI=1
81-
| AttachedNotToFSI=2
78+
| NotRunning
79+
| AttachedToFSI
80+
| AttachedNotToFSI
8281

8382
typeinternalFsiEditorSendAction=
84-
| ExecuteSelection=0
85-
| ExecuteLine=1
86-
| DebugSelection=2
83+
| ExecuteSelection
84+
| ExecuteLine
85+
| DebugSelection
8786

8887
[<Guid("dee22b65-9761-4a26-8fb2-759b971d6dfc")>]//REVIEW: double check fresh guid! IIRC it is.
8988
typeinternalFsiToolWindow()as this=
@@ -568,7 +567,13 @@ type internal FsiToolWindow() as this =
568567

569568
executeTextNoHistory interaction
570569

571-
letsendSelectionToFSI selectLine dbgBreak=
570+
letsendSelectionToFSI action=
571+
letdbgBreak,selectLine=
572+
match actionwith
573+
| ExecuteSelection->false,false
574+
| ExecuteLine->false,true
575+
| DebugSelection->true,false
576+
572577
try
573578
letdte= provider.GetService(typeof<DTE>):?> DTE
574579
letactiveD= dte.ActiveDocument
@@ -591,15 +596,15 @@ type internal FsiToolWindow() as this =
591596
// Example errors include no active document.
592597

593598
letonMLSendSelection(sender:obj)(e:EventArgs)=
594-
sendSelectionToFSIfalsefalse
599+
sendSelectionToFSIExecuteSelection
595600

596601
letonMLSendLine(sender:obj)(e:EventArgs)=
597-
sendSelectionToFSItruefalse
602+
sendSelectionToFSIExecuteLine
598603

599604
letonMLDebugSelection(sender:obj)(e:EventArgs)=
600605
if checkDebuggability()then
601606
attachDebugger()
602-
sendSelectionToFSIfalsetrue
607+
sendSelectionToFSIDebugSelection
603608

604609
/// Handle UP and DOWN. Cycle history.
605610
letonHistory(sender:obj)(e:EventArgs)=

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp