Commita3b458d

authored and

committed

ProjectNode.TransferItem doesn't try to do anything and returns E_INVALIDARG if oldMkDoc and newMkDoc are equal (dotnet#2467)

1 parent650c411 commita3b458dCopy full SHA for a3b458d

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5448,10 +5448,15 @@ public virtual int TransferItem(string oldMkDoc, string newMkDoc, IVsWindowFrame`
`5448`	`5448`	`{`
`5449`	`5449`	`returnVSConstants.E_FAIL;`
`5450`	`5450`	`}`
`5451`		`-//Fail if the document names passed are null.`
	`5451`	`+`
	`5452`	`+// Fail if the document names passed are null.`
`5452`	`5453`	`if(oldMkDoc==null\|\|newMkDoc==null)`
`5453`	`5454`	`returnVSConstants.E_INVALIDARG;`
`5454`	`5455`
	`5456`	`+// Fail if the document names passed are equal.`
	`5457`	`+if(oldMkDoc==newMkDoc)`
	`5458`	`+returnVSConstants.E_INVALIDARG;`
	`5459`	`+`
`5455`	`5460`	`inthr=VSConstants.S_OK;`
`5456`	`5461`	`VSDOCUMENTPRIORITY[]priority=newVSDOCUMENTPRIORITY[1];`
`5457`	`5462`	`uintitemid=VSConstants.VSITEMID_NIL;`

Comments

(0)