Commit9d5db9a

committed

remove double hash table lookup in NotifyNameResolution

1 parent8f92284 commit9d5db9aCopy full SHA for 9d5db9a

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1388,7 +1388,7 @@ type TcResultsSinkImpl(g, ?source: string) =`
`1388`	`1388`	`letcapturedNameResolutions= ResizeArray<_>()`
`1389`	`1389`	`letcapturedFormatSpecifierLocations= ResizeArray<_>()`
`1390`	`1390`	`letcapturedNameResolutionIdentifiers=`
`1391`		`-new System.Collections.Generic.Dictionary<pos* string, unit>`
	`1391`	`+new System.Collections.Generic.HashSet<pos* string>`
`1392`	`1392`	`({new IEqualityComparer<_>with`
`1393`	`1393`	`member__.GetHashCode((p:pos,i))= p.Line+101* p.Column+ hash i`
`1394`	`1394`	`member__.Equals((p1,i1),(p2,i2))= posEq p1 p2&& i1= i2})`
`@@ -1423,10 +1423,7 @@ type TcResultsSinkImpl(g, ?source: string) =`
`1423`	`1423`
`1424`	`1424`	`letalreadyDone=`
`1425`	`1425`	`match keyOptwith`
`1426`		`-\| Some key->`
`1427`		`-letres= capturedNameResolutionIdentifiers.ContainsKey key`
`1428`		`-ifnot resthen capturedNameResolutionIdentifiers.Add(key,())\|> ignore`
`1429`		`- res`
	`1426`	`+\| Some key->not(capturedNameResolutionIdentifiers.Add key)`
`1430`	`1427`	`\|_->false`
`1431`	`1428`
`1432`	`1429`	`if replacethen`

Comments

(0)