Commit8dc04ab

committed

Fixdotnet#123 - Union types without sub-classes should be sealed

1 parent742c133 commit8dc04abCopy full SHA for 8dc04ab

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1059,9 +1059,6 @@ let rec convClassUnionDef cenv enc td cud =`
`1059`	`1059`	`\|> List.filter(fun pd->not(cud.cudHasHelpers= SpecialFSharpListHelpers&&(pd.Name="Empty"\|\| pd.Name="IsEmpty"))&&`
`1060`	`1060`	`not(cud.cudHasHelpers= SpecialFSharpOptionHelpers&&(pd.Name="Value"\|\| pd.Name="None")))`
`1061`	`1061`
`1062`		`-letcasesTypeDef=`
`1063`		`- None`
`1064`		`-`
`1065`	`1062`	`letenumTypeDef=`
`1066`	`1063`	`// The nested Tags type is elided if there is only one tag`
`1067`	`1064`	`// The Tag property is NOT elided if there is only one tag`
`@@ -1095,15 +1092,14 @@ let rec convClassUnionDef cenv enc td cud =`
`1095`	`1092`
`1096`	`1093`	`letbaseTypeDef=`
`1097`	`1094`	`{ Name= td.Name;`
`1098`		`- NestedTypes= mkILTypeDefs(Option.toList casesTypeDef@`
`1099`		`- Option.toList enumTypeDef@`
	`1095`	`+ NestedTypes= mkILTypeDefs(Option.toList enumTypeDef@`
`1100`	`1096`	`altTypeDefs@`
`1101`	`1097`	`altDebugTypeDefs@`
`1102`	`1098`	`(convTypeDefs cenv(enc@[td]) td.NestedTypes).AsList);`
`1103`	`1099`	`GenericParams= td.GenericParams;`
`1104`	`1100`	`Access= td.Access;`
`1105`	`1101`	`IsAbstract= isAbstract;`
`1106`		`- IsSealed=false;`
	`1102`	`+ IsSealed=altTypeDefs.IsEmpty;`
`1107`	`1103`	`IsSerializable=td.IsSerializable;`
`1108`	`1104`	`IsComInterop=false;`
`1109`	`1105`	`Layout=td.Layout;`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1368,6 +1368,8 @@ module bug872632 =`
`1368`	`1368`
`1369`	`1369`	`do check"bug872632" Foo.x.Length8`
`1370`	`1370`
	`1371`	`+do check"vwllfewlkefwl"(typedefof<list<int>>.IsSealed)true`
	`1372`	`+`
`1371`	`1373`	`modulemanyIndexes=`
`1372`	`1374`	`openSystem`
`1373`	`1375`

Comments

(0)