Commit85d323d

smoothdeveloper

authored and

KevinRansom

committed

Tastops.fullNameOfParentOfNonLocalEntityRef and Tastops.fullNameOfParentOfNonLocalEntityRefAsLayout used to perform two comparison by accessing nested properties (up to 4 get per call:nlr.Path.Length = 0 || nlr.Path.Length = 1 (dotnet#2295)

replaced with `nlr.Path.Length < 2`

1 parent1e7bb92 commit85d323dCopy full SHA for 85d323d

File tree

1 file changed

-2

lines changed

src/fsharp
- TastOps.fs

1 file changed

-2

lines changed

`‎src/fsharp/TastOps.fs‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2472,11 +2472,11 @@ let fullNameOfPubPath (PubPath(p)) = textOfPath p`
`2472`	`2472`	`letfullNameOfPubPathAsLayout(PubPath(p))= layoutOfPath(Array.toList p)`
`2473`	`2473`
`2474`	`2474`	`letfullNameOfParentOfNonLocalEntityRef(nlr:NonLocalEntityRef)=`
`2475`		`-if nlr.Path.Length=0\|\| nlr.Path.Length=1then None`
	`2475`	`+if nlr.Path.Length<2then None`
`2476`	`2476`	`else Some(textOfPath nlr.EnclosingMangledPath)// <--- BAD BAD BAD: this is a mangled path. This is wrong for nested modules`
`2477`	`2477`
`2478`	`2478`	`letfullNameOfParentOfNonLocalEntityRefAsLayout(nlr:NonLocalEntityRef)=`
`2479`		`-if nlr.Path.Length=0\|\| nlr.Path.Length=1then None`
	`2479`	`+if nlr.Path.Length<2then None`
`2480`	`2480`	`else Some(layoutOfPath(List.ofArray nlr.EnclosingMangledPath))// <--- BAD BAD BAD: this is a mangled path. This is wrong for nested modules`
`2481`	`2481`
`2482`	`2482`	`letfullNameOfParentOfEntityRef eref=`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit85d323d

File tree

1 file changed

1 file changed

`‎src/fsharp/TastOps.fs‎`

0 commit comments