Commit6f99029

committed

Obsolete members are now also omitted in QuickInfo - referencesdotnet#50

1 parentae54746 commit6f99029Copy full SHA for 6f99029

File tree

+17

-10

lines changed

+17

-10

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1504,8 +1504,8 @@ module private TastDefinitionPrinting =`
`1504`	`1504`	`// Don't print individual methods forming interface implementations - these are currently never exported`
`1505`	`1505`	`not(isInterfaceTy denv.g oty)`
`1506`	`1506`	`\|[]->true)`
`1507`		`-\|> List.filter(fun v-> denv.showObsoleteMembers\|\|not(HasFSharpAttribute denv.g denv.g.attrib_SystemObsolete v.Attribs))`
`1508`		`-\|> List.filter(fun v->not(Infos.AttributeChecking.CheckFSharpAttributesForHidden denv.g v.Attribs))`
	`1507`	`+\|> List.filter(fun v-> denv.showObsoleteMembers\|\|not(Infos.AttributeChecking.CheckFSharpAttributesForObsolete denv.g v.Attribs))`
	`1508`	`+\|> List.filter(fun v->denv.showHiddenMembers\|\|not(Infos.AttributeChecking.CheckFSharpAttributesForHidden denv.g v.Attribs))`
`1509`	`1509`	`// sort`
`1510`	`1510`	`letsortKey(v:ValRef)=(not v.IsConstructor,// constructors before others`
`1511`	`1511`	`v.Id.idText,// sort by name`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -548,11 +548,13 @@ let runFromCommandLineToImportingAssemblies(displayPSTypeProviderSecurityDialogB`
`548`	`548`	`// Code from here on down is just used by fsc.exe`
`549`	`549`	`///////////////////////////////////////////////////////////////////////////////////////////////////////////////`
`550`	`550`
`551`		`-letBuildInitialDisplayEnvForDocGeneration tcGlobals=`
	`551`	`+letBuildInitialDisplayEnvForSigFileGeneration tcGlobals=`
`552`	`552`	`letdenv= DisplayEnv.Empty tcGlobals`
`553`	`553`	`letdenv=`
`554`	`554`	`{ denvwith`
`555`	`555`	`showImperativeTyparAnnotations=true;`
	`556`	`+ showHiddenMembers=true;`
	`557`	`+ showObsoleteMembers=true;`
`556`	`558`	`showAttributes=true;}`
`557`	`559`	`denv.SetOpenPaths`
`558`	`560`	`[ FSharpLib.RootPath`
`@@ -577,7 +579,7 @@ module InterfaceFileWriter =`
`577`	`579`	`fprintfn os""`
`578`	`580`
`579`	`581`	`for(TImplFile(_,_,mexpr,_,_))in declaredImplsdo`
`580`		`-letdenv=BuildInitialDisplayEnvForDocGeneration tcGlobals`
	`582`	`+letdenv=BuildInitialDisplayEnvForSigFileGeneration tcGlobals`
`581`	`583`	`writeViaBufferWithEnvironmentNewLines os(fun os s-> Printf.bprintf os"%s\n\n" s)`
`582`	`584`	`(NicePrint.layoutInferredSigOfModuleExprtrue denv infoReader AccessibleFromSomewhere range0 mexpr\|> Layout.squashTo80\|> Layout.showL)`
`583`	`585`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -2649,15 +2649,17 @@ module AttributeChecking =`
`2649`	`2649`	`v&&not(messageNumber=62&& g.mlCompatibility)`
`2650`	`2650`	`\|_->false)`
`2651`	`2651`
	`2652`	`+/// Indicate if a list of F# attributes contains 'ObsoleteAttribute'. Used to suppress the item in intellisense.`
	`2653`	`+letCheckFSharpAttributesForObsolete g attribs=`
	`2654`	`+ nonNil attribs&&(HasFSharpAttribute g g.attrib_SystemObsolete attribs)`
	`2655`	`+`
`2652`	`2656`	`/// Indicate if a list of F# attributes contains 'ObsoleteAttribute'. Used to suppress the item in intellisense.`
`2653`	`2657`	`/// Also check the attributes for CompilerMessageAttribute, which has an IsHidden argument that allows`
`2654`	`2658`	`/// items to be suppressed from intellisense.`
`2655`	`2659`	`letCheckFSharpAttributesForUnseen g attribs _m=`
`2656`		`- nonNil attribs&&`
`2657`		`-(letisObsolete= isSome(TryFindFSharpAttribute g g.attrib_SystemObsolete attribs)`
`2658`		`-letisHidden= CheckFSharpAttributesForHidden g attribs`
`2659`		`- isObsolete\|\| isHidden`
`2660`		`-)`
	`2660`	`+ nonNil attribs&&`
	`2661`	`+(CheckFSharpAttributesForObsolete g attribs\|\|`
	`2662`	`+ CheckFSharpAttributesForHidden g attribs)`
`2661`	`2663`
`2662`	`2664`	`#if EXTENSIONTYPING`
`2663`	`2665`	`/// Indicate if a list of provided attributes contains 'ObsoleteAttribute'. Used to suppress the item in intellisense.`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2354,6 +2354,7 @@ type DisplayEnv =`
`2354`	`2354`	`suppressNestedTypes:bool;`
`2355`	`2355`	`maxMembers:int option;`
`2356`	`2356`	`showObsoleteMembers:bool;`
	`2357`	`+ showHiddenMembers:bool;`
`2357`	`2358`	`showTyparBinding:bool;`
`2358`	`2359`	`showImperativeTyparAnnotations:bool;`
`2359`	`2360`	`suppressInlineKeyword:bool;`
`@@ -2384,7 +2385,8 @@ type DisplayEnv =`
`2384`	`2385`	`shortTypeNames=false;`
`2385`	`2386`	`suppressNestedTypes=false;`
`2386`	`2387`	`maxMembers=None;`
`2387`		`- showObsoleteMembers=true;`
	`2388`	`+ showObsoleteMembers=false;`
	`2389`	`+ showHiddenMembers=false;`
`2388`	`2390`	`showTyparBinding=false;`
`2389`	`2391`	`showImperativeTyparAnnotations=false;`
`2390`	`2392`	`suppressInlineKeyword=false;`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -590,6 +590,7 @@ type DisplayEnv =`
`590`	`590`	`suppressNestedTypes:bool;`
`591`	`591`	`maxMembers:int option;`
`592`	`592`	`showObsoleteMembers:bool;`
	`593`	`+ showHiddenMembers:bool;`
`593`	`594`	`showTyparBinding:bool;`
`594`	`595`	`showImperativeTyparAnnotations:bool;`
`595`	`596`	`suppressInlineKeyword:bool;`

Comments

(0)