Commit631401a

cartermp

authored and

KevinRansom

committed

Do not get the absolute value of Map's hash code (dotnet#6072)

Fixesdotnet#6068, where you could cause a `System.OverFlowException` by using a key and value that leads to calling `abs` on `Int32.MinValue`. This is invalid on .NET. The fix is to not call `abs`, since there's really no reason to make a hash code always positive.

1 parent23c626d commit631401aCopy full SHA for 631401a

File tree

1 file changed

-2

lines changed

src/fsharp/FSharp.Core
- map.fs

1 file changed

-2

lines changed

`‎src/fsharp/FSharp.Core/map.fs‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,7 @@ namespace Microsoft.FSharp.Collections`
`558`	`558`	`for(KeyValue(x,y))in thisdo`
`559`	`559`	`res<- combineHash res(hash x)`
`560`	`560`	`res<- combineHash res(Unchecked.hash y)`
`561`		`-absres`
	`561`	`+ res`
`562`	`562`
`563`	`563`	`overridethis.Equals(that)=`
`564`	`564`	`match thatwith`
`@@ -744,4 +744,4 @@ namespace Microsoft.FSharp.Collections`
`744`	`744`	`letempty<'Key,'Valuewhen'Key:comparison>= Map<'Key,'Value>.Empty`
`745`	`745`
`746`	`746`	`[<CompiledName("Count")>]`
`747`		`-letcount(table:Map<_,_>)= table.Count`
	`747`	`+letcount(table:Map<_,_>)= table.Count`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit631401a

File tree

1 file changed

1 file changed

`‎src/fsharp/FSharp.Core/map.fs‎`

0 commit comments