Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5c51d49

Browse files
enricosadalatkin
authored andcommitted
Fix all warnings, enable warning as error on all projects, other cleanup
commit 19c332f8666f38fc5de384e2d3dccd0781cf8090Author: latkin <latkin@microsoft.com>Date: Mon Dec 15 12:39:07 2014 -0800 Small fix to project filecommit bba830243fc9301438bde290982a6cec7bb74059Author: latkin <latkin@microsoft.com>Date: Mon Dec 15 11:12:20 2014 -0800 Add comment on new 'ignore' linescommit 696539894a4b42bba77daf2adce82c9d001cab96Merge:bf32157 cb61ba1Author: latkin <latkin@microsoft.com>Date: Mon Dec 15 10:38:47 2014 -0800 Merge branch 'no_warnings' ofhttps://git01.codeplex.com/forks/esada/fsharp into warncommit cb61ba1a48f6c68c449465356b6d02bdb11559d7Author: enricosada <enrico@sada.io>Date: Thu Nov 27 17:54:42 2014 +0100 ignore *.csproj.usercommit 4445d253be31ba617a5dd043f9da7bbe7a409044Author: enricosada <enrico@sada.io>Date: Thu Nov 27 09:43:03 2014 +0100 Deployment.sln set EnableOpenSource as default startup project ( without .suo file )commit 92752982632ece70756f2e9cd62cf5d2e3ae0230Author: enricosada <enrico@sada.io>Date: Wed Nov 26 17:16:09 2014 +0100 add vs tests inside solutioncommit eca91d6b9e2a7df546982e355f61ebf66a73704bAuthor: enricosada <enrico@sada.io>Date: Wed Nov 26 14:23:14 2014 +0100 add solution folder for templatescommit 6cd6aac5eaec0f9619552e50adb7de8728622d00Author: enricosada <enrico@sada.io>Date: Wed Nov 26 17:15:30 2014 +0100 reenable obsolete warning and fix warningscommit 3f068f5e68fe44a33a960600cc50eea68550a5a8Author: enricosada <enrico@sada.io>Date: Wed Nov 26 14:12:52 2014 +0100 reenabled warnings for xml doc and fix warningscommit 323ade800d535180bb4420ff2b3849d14c4235deAuthor: enricosada <enrico@sada.io>Date: Wed Nov 26 13:05:32 2014 +0100 suppress warning CS2008 ( no .cs file in project ) for template projectscommit a434bfa39fd7d58909c0ae78d750e1f5034cc2d3Author: enricosada <enrico@sada.io>Date: Tue Nov 25 19:26:27 2014 +0100 vs tests, unit tests platfom = x86commit 0a3f382c7c0d94ee36a7fa6d00d33e82a2408f82Author: enricosada <enrico@sada.io>Date: Tue Nov 25 18:04:17 2014 +0100 fix exec BuildTestTools.cmd from any working directorycommit a04a4674135fbefec8ac6ce63ff24ef6b67b4996Author: enricosada <enrico@sada.io>Date: Tue Nov 25 17:48:49 2014 +0100 add fail fast on BuildTestTools.cmdcommit 4d12a981c4c34a3b1332ee536c6cf1cf9b642e10Author: enricosada <enrico@sada.io>Date: Tue Nov 25 17:14:48 2014 +0100 removed unused reference to Microsoft.VisualStudio.CommonIDE, Version=9.0.0.0commit 218910678d09f4338d7a53e6b022d66de959b809Author: enricosada <enrico@sada.io>Date: Tue Nov 25 17:06:15 2014 +0100 fix use fsc NoWarn and OtherFlags only with fsharp projectscommit 1d95c427f62b530b24232d8af9f20af1e90816a9Author: enricosada <enrico@sada.io>Date: Tue Nov 25 12:33:57 2014 +0100 some fixcommit 2a0927f731e7ae3460bc6776737b1d45d4f22819Author: enricosada <enrico@sada.io>Date: Tue Nov 25 12:33:23 2014 +0100 dont lose call stack on rethrowcommit b0a7dd6697c5bb3af9d1cee62ca729d9796b70d6Author: enricosada <enrico@sada.io>Date: Tue Nov 25 12:32:55 2014 +0100 fix pure function called without assignment fix save with blank in pathcommit 0c039657a7bd252ab7f30494364e2e4b6d3ef7bdAuthor: enricosada <enrico@sada.io>Date: Tue Nov 25 12:32:09 2014 +0100 fix wrong param name for ArgumentExceptioncommit 06f73b3ac13a863e567d46f86f0ff9627188b7b3Author: enricosada <enrico@sada.io>Date: Tue Nov 25 12:01:52 2014 +0100 fix possible null refcommit 4c530286bdea65d98e6fd0f4a08d93783657d26bAuthor: enricosada <enrico@sada.io>Date: Tue Nov 25 12:01:27 2014 +0100 empty statementscommit 29cb31e174f54b0ce6f6b925585c902dc85df6e5Author: enricosada <enrico@sada.io>Date: Tue Nov 25 11:38:40 2014 +0100 fix warningscommit 926c9da8d46c0850ee0f3d67ced6ee31dc862042Author: enricosada <enrico@sada.io>Date: Tue Nov 25 11:13:06 2014 +0100 add visual studio sdk prereqcommit c97e00ebe43a08851aaa048981398273412b5c9aAuthor: enricosada <enrico@sada.io>Date: Wed Nov 19 16:17:19 2014 +0100 fix 'value is unused' warningscommit c602d91b7256f7311c8a795dd89cb1402a86c338Author: enricosada <enrico@sada.io>Date: Wed Nov 19 17:15:49 2014 +0100 enable treat warnings as errors on all projects
1 parentbf32157 commit5c51d49

File tree

66 files changed

+379
-94
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+379
-94
lines changed

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,3 +79,4 @@ vsintegration/src/vs/FsPkgs/FSharp.Project/FS/ctofiles/
7979
tests/fsharpqa/Source/CodeGen/EmittedIL/QueryExpressionStepping/Utils.dll
8080
tests/fsharpqa/Source/CodeGen/EmittedIL/ComputationExpressions/ComputationExprLibrary.dll
8181

82+
*.csproj.user

‎DEVGUIDE.html‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -399,6 +399,9 @@ <h3>3. Full Steps Before Running Tests</h3>
399399
</pre>
400400

401401
<h3>4. [Optional] Build and Install the Visual F# IDE Tools</h3>
402+
<p>
403+
Prerequisites:<ahref="http://msdn.microsoft.com/en-us/library/bb166441.aspx">Visual Studio Software Development Kit (SDK)</a>
404+
</p>
402405
<p>
403406
To build the VS components:
404407
</p>

‎src/FSharpSource.Settings.targets‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,14 @@
1010
<LkgVersion>4.0.30319.1</LkgVersion>
1111
<FsLexUnicode>true</FsLexUnicode>
1212
<ProjectLanguageCondition="'$(ProjectLanguage)' == ''">FSharp</ProjectLanguage>
13+
<DebugSymbols>true</DebugSymbols>
14+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
15+
<WarningsAsErrors />
16+
</PropertyGroup>
17+
18+
<PropertyGroupCondition=" '$(ProjectLanguage)' == 'FSharp'">
1319
<OtherFlags>$(OtherFlags) --times</OtherFlags>
1420
<NoWarn>$(NoWarn);69;65;54;61;75</NoWarn>
15-
<DebugSymbols>true</DebugSymbols>
1621
</PropertyGroup>
1722

1823
<!-- Standard interpretations of Debug and Release configurations-->

‎src/fsharp/FSharp.Compiler/FSharp.Compiler.fsproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<OutputType>Library</OutputType>
1212
<AssemblyName>FSharp.Compiler</AssemblyName>
1313
<DefineConstants>EXTENSIONTYPING;COMPILER;INCLUDE_METADATA_READER;INCLUDE_METADATA_WRITER;EXTENSIBLE_DUMPER;TYPE_PROVIDER_SECURITY;$(DefineConstants)</DefineConstants>
14-
<NoWarn>$(NoWarn);44;62;9</NoWarn>
14+
<NoWarn>$(NoWarn);62;9</NoWarn>
1515
<ProjectGuid>{2E4D67B4-522D-4CF7-97E4-BA940F0B18F3}</ProjectGuid>
1616
<AllowCrossTargeting>true</AllowCrossTargeting>
1717
<BaseAddress>0x06800000</BaseAddress>

‎src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Reflection/FSharpReflection.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ module PrimReflectionAdapters =
3838
memberthis.GetProperties()= this.GetRuntimeProperties()|> Array.ofSeq
3939
memberthis.GetMethod(name,parameterTypes)= this.GetRuntimeMethod(name, parameterTypes)
4040
memberthis.GetCustomAttributes(attrTy:Type,inherits:bool):obj[]=
41-
unbox(box(CustomAttributeExtensions.GetCustomAttributes(this.GetTypeInfo(), attrTy,false).ToArray()))
41+
unbox(box(CustomAttributeExtensions.GetCustomAttributes(this.GetTypeInfo(), attrTy,inherits).ToArray()))
4242

4343
typeSystem.Reflection.MemberInfowith
4444
memberthis.ReflectedType= this.DeclaringType

‎src/fsharp/FSharp.Core/FSharp.Core.fsproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<OutputType>Library</OutputType>
1313
<AssemblyName>FSharp.Core</AssemblyName>
1414
<DefineConstants>RUNTIME;$(DefineConstants)</DefineConstants>
15-
<NoWarn>44;45;55;62;75;1204</NoWarn>
15+
<NoWarn>$(NoWarn);45;55;62;75;1204</NoWarn>
1616
<BaseAddress>0x05000000</BaseAddress>
1717
<CompilingFsLib>true</CompilingFsLib>
1818
<AllowCrossTargeting>true</AllowCrossTargeting>

‎src/fsharp/FSharp.Core/prim-types.fs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ namespace Microsoft.FSharp.Core
396396
member inlinethis.GetProperty(name)= this.GetRuntimeProperty(name)
397397
member inlinethis.GetMethod(name,parameterTypes)= this.GetRuntimeMethod(name, parameterTypes)
398398
member inlinethis.GetCustomAttributes(attrTy:Type,inherits:bool):obj[]=
399-
unboxPrim<_>(box(CustomAttributeExtensions.GetCustomAttributes(this.GetTypeInfo(), attrTy,false).ToArray()))
399+
unboxPrim<_>(box(CustomAttributeExtensions.GetCustomAttributes(this.GetTypeInfo(), attrTy,inherits).ToArray()))
400400

401401
openPrimReflectionAdapters
402402

‎src/fsharp/FSharp.LanguageService.Compiler/FSharp.LanguageService.Compiler.fsproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<DefineConstants>NO_PDB_READER;$(DefineConstants)</DefineConstants>
2222
<DefineConstants>NO_PDB_WRITER;$(DefineConstants)</DefineConstants>
2323
<DefineConstants>NO_INLINE_IL_PARSER;$(DefineConstants)</DefineConstants>
24-
<NoWarn>$(NoWarn);62;44;9;75</NoWarn>
24+
<NoWarn>$(NoWarn);62;9;75</NoWarn>
2525
<ProjectGuid>{a437a6ec-5323-47c2-8f86-e2cac54ff152}</ProjectGuid>
2626
<AllowCrossTargeting>true</AllowCrossTargeting>
2727
<BaseAddress>0x06800000</BaseAddress>

‎src/fsharp/Fsc/Fsc.fsproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PlatformTarget>x86</PlatformTarget>
1515
<ProjectGuid>{C94C257C-3C0A-4858-B5D8-D746498D1F08}</ProjectGuid>
1616
<OutputType>Exe</OutputType>
17-
<NoWarn>$(NoWarn);62;44</NoWarn>
17+
<NoWarn>$(NoWarn);62</NoWarn>
1818
<AssemblyName>fsc</AssemblyName>
1919
<DefineConstants>EXTENSIONTYPING;COMPILER;$(DefineConstants)</DefineConstants>
2020
<AllowCrossTargeting>true</AllowCrossTargeting>

‎src/fsharp/build.fs‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3950,6 +3950,10 @@ type TcImports(tcConfigP:TcConfigProvider, initialResolutions:TcAssemblyResoluti
39503950
letphase2()=
39513951
#if EXTENSIONTYPING
39523952
ccuinfo.TypeProviders<- tcImports.ImportTypeProviderExtensions(tpApprovals, displayPSTypeProviderSecurityDialogBlockingUI, tcConfig, filename, ilScopeRef, ilModule.ManifestOfAssembly.CustomAttrs.AsList, ccu.Contents, invalidateCcu, m)
3953+
#else
3954+
// to prevent unused parameter warning
3955+
ignore tpApprovals
3956+
ignore displayPSTypeProviderSecurityDialogBlockingUI
39533957
#endif
39543958
[ResolvedImportedAssembly(ccuinfo)]
39553959
phase2
@@ -4076,6 +4080,10 @@ type TcImports(tcConfigP:TcConfigProvider, initialResolutions:TcAssemblyResoluti
40764080
#if EXTENSIONTYPING
40774081
ccuinfo.TypeProviders<- tcImports.ImportTypeProviderExtensions(tpApprovals, displayPSTypeProviderSecurityDialogBlockingUI, tcConfig, filename, ilScopeRef, ilModule.ManifestOfAssembly.CustomAttrs.AsList, ccu.Contents, invalidateCcu, m)
40784082
#else
4083+
// to prevent unused parameter warning
4084+
ignore tpApprovals
4085+
ignore displayPSTypeProviderSecurityDialogBlockingUI
4086+
40794087
()
40804088
#endif
40814089
data,ccuinfo,phase2)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp