Commit5c04a89

authored

Merge pull requestdotnet#4646 from brettfo/reference-alias-hack

ensure reference alias is set before csc is invoked

2 parents284cb2f +d222ead commit5c04a89Copy full SHA for 5c04a89

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -72,13 +72,13 @@`
`72`	`72`	`<PackageReferenceInclude="VSSDK.VSLangProj.8"Version="$(VSSDKVSLangProj8PackageVersion)" />`
`73`	`73`	`</ItemGroup>`
`74`	`74`
`75`		`- <TargetName="HACK_AddAliasToMicrosoftVisualStudioShell140"BeforeTargets="ResolveReferences">`
	`75`	`+ <TargetName="HACK_AddAliasToMicrosoftVisualStudioShell140"BeforeTargets="CoreCompile">`
`76`	`76`	`<ItemGroup>`
`77`	`77`	`<!--`
`78`	`78`	`We require a reference to Microsoft.VisualStudio.Shell.14.0.dll, but that causes some issues with duplicate type`
`79`	`79`	`names. The ~hack~ fix is to include the package reference and ensure the Aliases metadata gets set afterwards.`
`80`	`80`	`-->`
`81`		`- <ReferencePathUpdate="%(Identity)"Aliases="Shell14"Condition="'%(ReferencePath.PackageName)' == 'Microsoft.VisualStudio.Shell.14.0'" />`
	`81`	`+ <ReferencePathWithRefAssembliesUpdate="%(Identity)"Aliases="Shell14"Condition="'%(ReferencePathWithRefAssemblies.NuGetPackageId)' == 'Microsoft.VisualStudio.Shell.14.0'" />`
`82`	`82`	`</ItemGroup>`
`83`	`83`	`</Target>`
`84`	`84`

Comments

(0)