Commit5af8810

authored and

committed

Fixed hard crash in VS when specific F# code is used. (dotnet#5617)

* Fixed hard crash in VS by simply not re-raising exceptions when parsing in our service layer* Using instance instead of static errorlogger

1 parent04f3a36 commit5af8810Copy full SHA for 5af8810

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1598,7 +1598,7 @@ module internal Parser =`
`1598`	`1598`	`letisExe= options.IsExe`
`1599`	`1599`	`try Some(ParseInput(lexfun, errHandler.ErrorLogger, lexbuf, None, fileName,(isLastCompiland, isExe)))`
`1600`	`1600`	`with e->`
`1601`		`- errHandler.ErrorLogger.ErrorR(e)`
	`1601`	`+ errHandler.ErrorLogger.StopProcessingRecovery e Range.range0// don't re-raise any exceptions, we must return None.`
`1602`	`1602`	`None)`
`1603`	`1603`	`errHandler.CollectedDiagnostics, parseResult, errHandler.AnyErrors`
`1604`	`1604`

Comments

(0)