Commit5ab7886

committed

Remove unnecessary access modifier conversions for abstract class ctors

1 parent1251430 commit5ab7886Copy full SHA for 5ab7886

File tree

-15

lines changed

-15

lines changed

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -5291,14 +5291,6 @@ and GenMethodForBinding`
`5291`	`5291`	`letilMethTypars= ilTypars\|> List.drop mspec.EnclosingType.GenericArgs.Length`
`5292`	`5292`	`if memberInfo.MemberFlags.MemberKind= MemberKind.Constructorthen`
`5293`	`5293`	`assert(isNil ilMethTypars)`
`5294`		`-`
`5295`		`-// Constructors in abstract classes become protected`
`5296`		`-letaccess=`
`5297`		`-if HasFSharpAttribute cenv.g cenv.g.attrib_AbstractClassAttribute v.MemberApparentParent.Attribsthen`
`5298`		`- ILMemberAccess.Family`
`5299`		`-else`
`5300`		`- access`
`5301`		`-`
`5302`	`5294`	`letmdef= mkILCtor(access,ilParams,ilMethodBody)`
`5303`	`5295`	`letmdef={ mdefwith CustomAttrs= mkILCustomAttrs(ilAttrsThatGoOnPrimaryItem@ sourceNameAttribs@ ilAttrsCompilerGenerated)};`
`5304`	`5296`	`EmitTheMethodDef mdef`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1037,13 +1037,6 @@ let rec convClassUnionDef cenv enc td cud =`
`1037`	`1037`	`// The class can be abstract if each alternative is represented by a derived type`
`1038`	`1038`	`letisAbstract=(altTypeDefs.Length= cud.cudAlternatives.Length)`
`1039`	`1039`
`1040`		`-// If the class is abstract make the constructor used for the subclasses protected`
`1041`		`-letctorMeths=`
`1042`		`-if isAbstractthen`
`1043`		`- ctorMeths\|> List.map(fun mdef->{mdefwith Access=ILMemberAccess.Assembly})`
`1044`		`-else`
`1045`		`- ctorMeths`
`1046`		`-`
`1047`	`1040`	`letexistingMeths=`
`1048`	`1041`	`td.Methods.AsList`
`1049`	`1042`	`// Filter out the F#-compiler supplied implementation of the get_Empty method. This is because we will replace`

Comments

(0)