Commit4064694

authored

Fixed byref extension methods from not showing up in completions (dotnet#5552)

1 parent1ac49af commit4064694Copy full SHA for 4064694

File tree

+29

-0

lines changed

+29

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2765,6 +2765,7 @@ let IsApplicableMethApprox g amap m (minfo:MethInfo) availObjTy =`
`2765`	`2765`	`letminst= FreshenMethInfo m minfo`
`2766`	`2766`	`match minfo.GetObjArgTypes(amap, m, minst)with`
`2767`	`2767`	`\|[reqdObjTy]->`
	`2768`	`+letreqdObjTy=if isByrefTy g reqdObjTythen destByrefTy g reqdObjTyelse reqdObjTy// This is to support byref extension methods.`
`2768`	`2769`	`TryD(fun()-> SolveTypeSubsumesType csenv0 m NoTrace None reqdObjTy availObjTy++(fun()-> ResultDtrue))`
`2769`	`2770`	`(fun _err-> ResultDfalse)`
`2770`	`2771`	`\|> CommitOperationResult`

Lines changed: 28 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -602,6 +602,34 @@ module M2 =`
`602`	`602`	`"""`
`603`	`603`	`VerifyCompletionList(fileContents," Ext",["Extensions";"ExtraTopLevelOperators"],[])`
`604`	`604`
	`605`	`+[<Test>]`
	`606`	+let``Byref Extension Methods``()=
	`607`	`+letfileContents="""`
	`608`	`+module Extensions =`
	`609`	`+ open System`
	`610`	`+ open System.Runtime.CompilerServices`
	`611`	`+`
	`612`	`+ [<Struct>]`
	`613`	`+ type Message = Message of String`
	`614`	`+`
	`615`	`+ [<Sealed; AbstractClass; Extension>]`
	`616`	`+ type MessageExtensions private () =`
	`617`	`+ let (\|Message\|) (Message message) = message`
	`618`	`+`
	`619`	`+ [<Extension>]`
	`620`	`+ static member Print (Message message : Message) =`
	`621`	`+ printfn "%s" message`
	`622`	`+`
	`623`	`+ [<Extension>]`
	`624`	`+ static member PrintRef (Message message : inref<Message>) =`
	`625`	`+ printfn "%s" message`
	`626`	`+`
	`627`	`+ let wrappedMessage = Message "Hello World"`
	`628`	`+`
	`629`	`+ wrappedMessage.`
	`630`	`+"""`
	`631`	`+ VerifyCompletionList(fileContents,"wrappedMessage.",["PrintRef"],[])`
	`632`	`+`
`605`	`633`	`#if EXE`
`606`	`634`	`ShouldDisplaySystemNamespace()`
`607`	`635`	`#endif`

Comments

(0)