Commit3e71220

kasper3

authored and

KevinRansom

committed

Add WarningsNotAsErrors option (dotnet#4562)

* Add WarningsNotAsErrors optionCorresponding compiler option is `warnaswarn`.* Use `--warnaserror-` instead of new option* Add a unit test for WarningsNotAsErrors

1 parent1f07561 commit3e71220Copy full SHA for 3e71220

File tree

4 files changed

+38

-0

lines changed

src/fsharp/FSharp.Build
- Fsc.fs
vsintegration
- src/FSharp.ProjectSystem.Base/Project
  - ProjectConfig.cs
  - ProjectFileConstants.cs
- tests/UnitTests
  - Tests.Build.fs

4 files changed

+38

-0

lines changed

`‎src/fsharp/FSharp.Build/Fsc.fs‎`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,7 @@ type public Fsc () as this =`
`73`	`73`	`let mutabletreatWarningsAsErrors:bool=false`
`74`	`74`	`let mutableuseStandardResourceNames:bool=false`
`75`	`75`	`let mutablewarningsAsErrors:string=null`
	`76`	`+let mutablewarningsNotAsErrors:string=null`
`76`	`77`	`let mutableversionFile:string=null`
`77`	`78`	`let mutablewarningLevel:string=null`
`78`	`79`	`let mutablewin32res:string=null`
`@@ -195,6 +196,11 @@ type public Fsc () as this =`
`195`	`196`
`196`	`197`	`builder.AppendSwitchIfNotNull("--warnaserror:", warningsAsErrorsArray,",")`
`197`	`198`
	`199`	`+// WarningsNotAsErrors`
	`200`	`+match warningsNotAsErrorswith`
	`201`	`+\|null->()`
	`202`	`+\|_-> builder.AppendSwitchIfNotNull("--warnaserror-:", warningsNotAsErrors.Split([\|' ';';';','\|], StringSplitOptions.RemoveEmptyEntries),",")`
	`203`	`+`
`198`	`204`	`// Win32ResourceFile`
`199`	`205`	`builder.AppendSwitchIfNotNull("--win32res:", win32res)`
`200`	`206`
`@@ -448,6 +454,10 @@ type public Fsc () as this =`
`448`	`454`	`with get()= warningsAsErrors`
`449`	`455`	`andset(s)= warningsAsErrors<- s`
`450`	`456`
	`457`	`+memberfsc.WarningsNotAsErrors`
	`458`	`+with get()= warningsNotAsErrors`
	`459`	`+andset(s)= warningsNotAsErrors<- s`
	`460`	`+`
`451`	`461`	`memberfsc.VisualStudioStyleErrors`
`452`	`462`	`with get()= vserrors`
`453`	`463`	`andset(p)= vserrors<- p`

`‎vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectConfig.cs‎`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -554,6 +554,18 @@ public string TreatSpecificWarningsAsErrors`
`554`	`554`	`}`
`555`	`555`	`}`
`556`	`556`
	`557`	`+publicstringTreatSpecificWarningsAsWarnings`
	`558`	`+{`
	`559`	`+get`
	`560`	`+{`
	`561`	`+returnGetConfigurationProperty(ProjectFileConstants.WarningsNotAsErrors,false);`
	`562`	`+}`
	`563`	`+set`
	`564`	`+{`
	`565`	`+SetConfigurationProperty(ProjectFileConstants.WarningsNotAsErrors,value);`
	`566`	`+}`
	`567`	`+}`
	`568`	`+`
`557`	`569`	`publicstringDocumentationFile`
`558`	`570`	`{`
`559`	`571`	`get`

`‎vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectFileConstants.cs‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,7 @@ internal static class ProjectFileConstants`
`130`	`130`	`publicconststringNoWarn="NoWarn";`
`131`	`131`	`publicconststringTreatWarningsAsErrors="TreatWarningsAsErrors";`
`132`	`132`	`publicconststringWarningsAsErrors="WarningsAsErrors";`
	`133`	`+publicconststringWarningsNotAsErrors="WarningsNotAsErrors";`
`133`	`134`	`publicconststringDocumentationFile="DocumentationFile";`
`134`	`135`	`publicconststringOtherFlags="OtherFlags";`
`135`	`136`	`publicconststringPlatformTarget="PlatformTarget";`

`‎vsintegration/tests/UnitTests/Tests.Build.fs‎`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,21 @@ type Build() =`
`171`	`171`	`"--highentropyva-"+ Environment.NewLine)`
`172`	`172`	`cmd`
`173`	`173`
	`174`	`+[<Test>]`
	`175`	`+memberpublicthis.TestWarningsNotAsErrors()=`
	`176`	`+lettool=new Microsoft.FSharp.Build.Fsc()`
	`177`	`+ tool.WarningsNotAsErrors<-"52;109"`
	`178`	`+ AssertEqual"52;109" tool.WarningsNotAsErrors`
	`179`	`+letcmd= tool.InternalGenerateResponseFileCommands()`
	`180`	`+ printfn"cmd=\"%s\"" cmd`
	`181`	`+ AssertEqual("--optimize+"+ Environment.NewLine+`
	`182`	`+"--warnaserror-:52,109"+ Environment.NewLine+`
	`183`	`+"--warnaserror:76"+ Environment.NewLine+`
	`184`	`+"--fullpaths"+ Environment.NewLine+`
	`185`	`+"--flaterrors"+ Environment.NewLine+`
	`186`	`+"--highentropyva-"+ Environment.NewLine)`
	`187`	`+ cmd`
	`188`	`+`
`174`	`189`	`[<Test>]`
`175`	`190`	`memberpublicthis.TestVersionFile()=`
`176`	`191`	`lettool=new Microsoft.FSharp.Build.Fsc()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3e71220

File tree

4 files changed

4 files changed

`‎src/fsharp/FSharp.Build/Fsc.fs‎`

`‎vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectConfig.cs‎`

`‎vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectFileConstants.cs‎`

`‎vsintegration/tests/UnitTests/Tests.Build.fs‎`

0 commit comments