Commit3b91f24

authored and

committed

Optimize Mapfold (dotnet#2280)

* optimize mapfold* using optimized closure for size 1 list

1 parent50c3c32 commit3b91f24Copy full SHA for 3b91f24

File tree

-8

lines changed

-8

lines changed

Lines changed: 7 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -407,14 +407,13 @@ module List =`
`407`	`407`
`408`	`408`	`// must be tail recursive`
`409`	`409`	`letmapFold(f:'a->'b->'c* 'a)(s:'a)(l:'b list):'c list* 'a=`
`410`		`-// microbenchmark suggested this implementation is faster than the simpler recursive one, and this function is called a lot`
`411`		`-let mutables= s`
`412`		`-let mutabler=[]`
`413`		`-for xin ldo`
`414`		`-letx',s'= f s x`
`415`		`- s<- s'`
`416`		`- r<- x':: r`
`417`		`- List.rev r, s`
	`410`	`+match lwith`
	`411`	`+\|[]->[], s`
	`412`	`+\|[h]->letf= OptimizedClosures.FSharpFunc<_,_,_>.Adapt(f)`
	`413`	`+leth',s'= f.Invoke(s, h)`
	`414`	`+[h'], s'`
	`415`	`+\|_->`
	`416`	`+ List.mapFold f s l`
`418`	`417`
`419`	`418`	`// Not tail recursive`
`420`	`419`	`let recmapFoldBack f l s=`

Comments

(0)