NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit31b7f52

committed

Removed updating project info on document open and document changed

1 parenta3d131e commit31b7f52Copy full SHA for 31b7f52

File tree

1 file changed

-13

lines changed

vsintegration/src/FSharp.Editor/LanguageService
- LanguageService.fs

1 file changed

-13

lines changed

`‎vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs‎`

Lines changed: 1 addition & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,6 @@ type internal FSharpLanguageService(package : FSharpPackage) =`
`427`	`427`	`memberprivatethis.OnProjectAdded(projectId:ProjectId)= projectInfoManager.UpdateProjectInfoWithProjectId(projectId,"OnProjectAdded", invalidateConfig=true)`
`428`	`428`	`memberprivatethis.OnProjectReloaded(projectId:ProjectId)= projectInfoManager.UpdateProjectInfoWithProjectId(projectId,"OnProjectReloaded", invalidateConfig=true)`
`429`	`429`	`memberprivatethis.OnDocumentAdded(projectId:ProjectId,documentId:DocumentId)= projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId,"OnDocumentAdded", invalidateConfig=true)`
`430`		`-memberprivatethis.OnDocumentChanged(projectId:ProjectId,documentId:DocumentId)= projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId,"OnDocumentChanged", invalidateConfig=false)`
`431`	`430`	`memberprivatethis.OnDocumentReloaded(projectId:ProjectId,documentId:DocumentId)= projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId,"OnDocumentReloaded", invalidateConfig=true)`
`432`	`431`
`433`	`432`	`overridethis.Initialize()=`
`@@ -439,7 +438,6 @@ type internal FSharpLanguageService(package : FSharpPackage) =`
`439`	`438`	`\| WorkspaceChangeKind.ProjectAdded-> this.OnProjectAdded(args.ProjectId)`
`440`	`439`	`\| WorkspaceChangeKind.ProjectReloaded-> this.OnProjectReloaded(args.ProjectId)`
`441`	`440`	`\| WorkspaceChangeKind.DocumentAdded-> this.OnDocumentAdded(args.ProjectId, args.DocumentId)`
`442`		`-\| WorkspaceChangeKind.DocumentChanged-> this.OnDocumentChanged(args.ProjectId, args.DocumentId)`
`443`	`441`	`\| WorkspaceChangeKind.DocumentReloaded-> this.OnDocumentReloaded(args.ProjectId, args.DocumentId)`
`444`	`442`	`\| WorkspaceChangeKind.DocumentRemoved`
`445`	`443`	`\| WorkspaceChangeKind.ProjectRemoved`
`@@ -686,17 +684,7 @@ type internal FSharpLanguageService(package : FSharpPackage) =`
`686`	`684`
`687`	`685`	`letfileContents= VsTextLines.GetFileContents(textLines, textViewAdapter)`
`688`	`686`	`this.SetupStandAloneFile(filename, fileContents, this.Workspace, hier)`
`689`		`-\| id->`
`690`		`-`
`691`		`-// This is the path when opening in-project .fs/.fsi files in CPS projects when`
`692`		`-// there is already an existing DocumentId for that document in the solution (which`
`693`		`-// will normally be the case)`
`694`		`-//`
`695`		`-// However, it is not clear this call to UpdateProjectInfoWithProjectId is needed, and it seems`
`696`		`-// harmful as it will cause a complete recheck of the project every time a view for a file in the`
`697`		`-// project is freshly opened.`
`698`		`-`
`699`		`- projectInfoManager.UpdateProjectInfoWithProjectId(id.ProjectId,"SetupNewTextView", invalidateConfig=true)`
	`687`	`+\|_->()`
`700`	`688`	`\|_->`
`701`	`689`
`702`	`690`	`// This is the path for both in-project and out-of-project .fsx files`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit31b7f52

File tree

1 file changed

1 file changed

`‎vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs‎`

0 commit comments