Commit2c3cfbf

authored and

committed

fix tuple warnings (dotnet#4389)

* fix tuple warnings* fix tuple warnings* fix tuple warnings* fix tuple warnings

1 parent7131143 commit2c3cfbfCopy full SHA for 2c3cfbf

File tree

+15

-3

lines changed

+15

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ let MethInfoChecks g amap isInstance tyargsOpt objArgs ad m (minfo:MethInfo) =`
`174`	`174`	`if not (IsTypeAndMethInfoAccessible amap m adOriginal ad minfo) then`
`175`	`175`	`error (Error (FSComp.SR.tcMethodNotAccessible(minfo.LogicalName), m))`
`176`	`176`
`177`		`- if isAnyTupleTy g minfo.ApparentEnclosingTypethen`
	`177`	`+ if isAnyTupleTy g minfo.ApparentEnclosingType&& not minfo.IsExtensionMember && (minfo.LogicalName.StartsWith "get_Item" \|\| minfo.LogicalName.StartsWith "get_Rest") then`
`178`	`178`	`warning (Error (FSComp.SR.tcTupleMemberNotNormallyUsed(), m))`
`179`	`179`
`180`	`180`	`CheckMethInfoAttributes g m tyargsOpt minfo \|> CommitOperationResult`

Lines changed: 14 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`
`2`	`2`	`moduleM`
`3`		`-`
	`3`	`+openSystem`
`4`	`4`	`typeMyRec={ Foo:string}`
`5`	`5`
`6`	`6`	`letx:int=1`
`@@ -47,4 +47,16 @@ let x1 =`
`47`	`47`	`(1,2,3,4,5,6,7,8).Item7]`
`48`	`48`
`49`	`49`	`letx2=(1,2,3,4,5,6,7,8).Rest// gives a warning`
`50`		`-letx3=(1,2).Rest// gives an actual error`
	`50`	`+letx3=(1,2).Rest// gives an actual error`
	`51`	`+letx4=(struct(1,2)).ToTuple()// no error or warning`
	`52`	`+`
	`53`	`+openSystem.Runtime.CompilerServices`
	`54`	`+`
	`55`	`+[<Extension>]`
	`56`	`+typeTupleEx()=`
	`57`	`+[<Extension>]`
	`58`	`+static member inlineDo((x,y):(int*string))=()`
	`59`	`+`
	`60`	`+letx=1,"2"`
	`61`	`+`
	`62`	`+x.Do()// no warning`

Comments

(0)