Commit293b115

vasily-kirichenko

authored and

KevinRansom

committed

Turn off closed files diagnostic analysis & fix creating IncrementalBuilder when a file opens (dotnet#2395)

* turn off closed files diagnostic analysisuse predefined BlockForCompletionItems option instead of hand made one* fixed: IncrementalBuilder is created every time a file in project opened / reopened

1 parent5739335 commit293b115Copy full SHA for 293b115

File tree

1 file changed

-10

lines changed

vsintegration/src/FSharp.Editor/Common
- LanguageService.fs

1 file changed

-10

lines changed

`‎vsintegration/src/FSharp.Editor/Common/LanguageService.fs‎`

Lines changed: 3 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -299,14 +299,11 @@ and`
`299`	`299`	`let recsetup(site:IProjectSite)=`
`300`	`300`	`letprojectGuid= Guid(site.ProjectGuid)`
`301`	`301`	`letprojectFileName= site.ProjectFileName()`
`302`		`-`
`303`	`302`	`letprojectDisplayName= projectDisplayNameOf projectFileName`
`304`		`-`
`305`	`303`	`letprojectId= workspace.ProjectTracker.GetOrCreateProjectIdForPath(projectFileName, projectDisplayName)`
`306`	`304`
`307`		`- projectInfoManager.UpdateProjectInfo(projectId, site, workspace)`
`308`		`-`
`309`	`305`	`if isNull(workspace.ProjectTracker.GetProject projectId)then`
	`306`	`+ projectInfoManager.UpdateProjectInfo(projectId, site, workspace)`
`310`	`307`	`letprojectContextFactory= package.ComponentModel.GetService<IWorkspaceProjectContextFactory>();`
`311`	`308`	`leterrorReporter= ProjectExternalErrorReporter(projectId,"FS", this.SystemServiceProvider)`
`312`	`309`
`@@ -369,12 +366,8 @@ and`
`369`	`366`	`workspace.Options<- workspace.Options.WithChangedOption(NavigationBarOptions.ShowNavigationBar, FSharpCommonConstants.FSharpLanguageName,true)`
`370`	`367`	`lettextViewAdapter= package.ComponentModel.GetService<IVsEditorAdaptersFactoryService>()`
`371`	`368`
`372`		`-letblockForCompletionOption=`
`373`		`- PerLanguageOption<bool>(`
`374`		`-"CompletionOptions","BlockForCompletionItems", defaultValue=true,`
`375`		`- storageLocations=[\| RoamingProfileStorageLocation("TextEditor.%%LANGUAGE%%.Specific.CompletionOptions - BlockForCompletionItems")\|])`
`376`		`-`
`377`		`- workspace.Options<- workspace.Options.WithChangedOption(blockForCompletionOption, FSharpCommonConstants.FSharpLanguageName,false)`
	`369`	`+ workspace.Options<- workspace.Options.WithChangedOption(Completion.CompletionOptions.BlockForCompletionItems, FSharpCommonConstants.FSharpLanguageName,false)`
	`370`	`+ workspace.Options<- workspace.Options.WithChangedOption(Shared.Options.ServiceFeatureOnOffOptions.ClosedFileDiagnostic, FSharpCommonConstants.FSharpLanguageName, Nullablefalse)`
`378`	`371`
`379`	`372`	`match textView.GetBuffer()with`
`380`	`373`	`\|(VSConstants.S_OK, textLines)->`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit293b115

File tree

1 file changed

1 file changed

`‎vsintegration/src/FSharp.Editor/Common/LanguageService.fs‎`

0 commit comments