Commit27a2b63

committed

do not abort overload resolution if parameter list contains errors

1 parent2851370 commit27a2b63Copy full SHA for 27a2b63

File tree

-1

lines changed

-1

lines changed

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3018,7 +3018,15 @@ let GetMethodArgs arg =`
`3018`	`3018`	`\| SynExpr.Const (SynConst.Unit,_) -> []`
`3019`	`3019`	`\| SynExprParen(SynExpr.Tuple (args,_,_),_,_,_) \| SynExpr.Tuple (args,_,_) -> args`
`3020`	`3020`	`\| SynExprParen(arg,_,_,_) \| arg -> [arg]`
`3021`		`- let unnamedCallerArgs,namedCallerArgs = List.takeUntil IsNamedArg args`
	`3021`	`+ let unnamedCallerArgs,namedCallerArgs =`
	`3022`	`+ args`
	`3023`	`+ \|> List.filter (fun arg ->`
	`3024`	`+ match arg with`
	`3025`	`+ // drop errors to avoid confusing error messages in cases like foo(a = 1,)`
	`3026`	`+ // here subsequent step will abort overload resolution complaining that name arguments should appear last`
	`3027`	`+ \| SynExpr.ArbitraryAfterError _ -> false`
	`3028`	`+ \| _ -> true)`
	`3029`	`+ \|> List.takeUntil IsNamedArg`
`3022`	`3030`	`let namedCallerArgs =`
`3023`	`3031`	`namedCallerArgs \|> List.choose (fun e ->`
`3024`	`3032`	`if not (IsNamedArg e) then`

Comments

(0)