NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit2527e68

authored

Merge pull requestdotnet#4905 from TIHan/perf-fixes1-dev15.7

Removed updating project info on document open and document changed - For dev15.7 branch

2 parentsd3f0242 +c30b3f5 commit2527e68Copy full SHA for 2527e68

File tree

1 file changed

-6

lines changed

vsintegration/src/FSharp.Editor/LanguageService
- LanguageService.fs

1 file changed

-6

lines changed

`‎vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs‎`

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,10 +57,10 @@ type internal FSharpCheckerProvider`
`57`	`57`	`letmmd= amd.GetModules().[0]`
`58`	`58`	`letmmr= mmd.GetMetadataReader()`
`59`	`59`
`60`		`-// "lifetime is timed to Metadata you got from the GetMetadata(…). As long as you hold it strongly, raw`
	`60`	`+// "lifetime is timed to Metadata you got from the GetMetadata(…). As long as you hold it strongly, raw`
`61`	`61`	`// memory we got from metadata reader will be alive. Once you are done, just let everything go and`
`62`	`62`	`// let finalizer handle resource rather than calling Dispose from Metadata directly. It is shared metadata.`
`63`		`-// You shouldn’t dispose it directly."`
	`63`	`+// You shouldn’t dispose it directly."`
`64`	`64`
`65`	`65`	`letobjToHold= box md`
`66`	`66`
`@@ -425,7 +425,6 @@ type internal FSharpLanguageService(package : FSharpPackage) =`
`425`	`425`	`memberprivatethis.OnProjectAdded(projectId:ProjectId)= projectInfoManager.UpdateProjectInfoWithProjectId(projectId,"OnProjectAdded", invalidateConfig=true)`
`426`	`426`	`memberprivatethis.OnProjectReloaded(projectId:ProjectId)= projectInfoManager.UpdateProjectInfoWithProjectId(projectId,"OnProjectReloaded", invalidateConfig=true)`
`427`	`427`	`memberprivatethis.OnDocumentAdded(projectId:ProjectId,documentId:DocumentId)= projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId,"OnDocumentAdded", invalidateConfig=true)`
`428`		`-memberprivatethis.OnDocumentChanged(projectId:ProjectId,documentId:DocumentId)= projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId,"OnDocumentChanged", invalidateConfig=false)`
`429`	`428`	`memberprivatethis.OnDocumentReloaded(projectId:ProjectId,documentId:DocumentId)= projectInfoManager.UpdateDocumentInfoWithProjectId(projectId, documentId,"OnDocumentReloaded", invalidateConfig=true)`
`430`	`429`
`431`	`430`	`overridethis.Initialize()=`
`@@ -437,7 +436,6 @@ type internal FSharpLanguageService(package : FSharpPackage) =`
`437`	`436`	`\| WorkspaceChangeKind.ProjectAdded-> this.OnProjectAdded(args.ProjectId)`
`438`	`437`	`\| WorkspaceChangeKind.ProjectReloaded-> this.OnProjectReloaded(args.ProjectId)`
`439`	`438`	`\| WorkspaceChangeKind.DocumentAdded-> this.OnDocumentAdded(args.ProjectId, args.DocumentId)`
`440`		`-\| WorkspaceChangeKind.DocumentChanged-> this.OnDocumentChanged(args.ProjectId, args.DocumentId)`
`441`	`439`	`\| WorkspaceChangeKind.DocumentReloaded-> this.OnDocumentReloaded(args.ProjectId, args.DocumentId)`
`442`	`440`	`\| WorkspaceChangeKind.DocumentRemoved`
`443`	`441`	`\| WorkspaceChangeKind.ProjectRemoved`
`@@ -672,8 +670,7 @@ type internal FSharpLanguageService(package : FSharpPackage) =`
`672`	`670`	`ifnot(h.IsCapabilityMatch("CPS"))then`
`673`	`671`	`letfileContents= VsTextLines.GetFileContents(textLines, textViewAdapter)`
`674`	`672`	`this.SetupStandAloneFile(filename, fileContents, this.Workspace, hier)`
`675`		`-\| id->`
`676`		`- projectInfoManager.UpdateProjectInfoWithProjectId(id.ProjectId,"SetupNewTextView", invalidateConfig=true)`
	`673`	`+\|_->()`
`677`	`674`	`\|_->`
`678`	`675`	`letfileContents= VsTextLines.GetFileContents(textLines, textViewAdapter)`
`679`	`676`	`this.SetupStandAloneFile(filename, fileContents, this.Workspace, hier)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2527e68

File tree

1 file changed

1 file changed

`‎vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs‎`

0 commit comments