Commit2521f81

authored and

committed

Equality is 0 (dotnet#4493)

* Create a test that shows broken comparison on float32* fix comparison of float32

1 parent4952f84 commit2521f81Copy full SHA for 2521f81

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4167,7 +4167,7 @@ namespace Microsoft.FSharp.Core`
`4167`	`4167`	`else(#"ceq" e1 e1: int #)`
`4168`	`4168`	`when^T: float32=if(#"clt" e1 e2: bool #)then(-1)`
`4169`	`4169`	`elif(#"cgt" e1 e2: bool #)then(1)`
`4170`		`-elif(#"ceq" e1 e2: bool #)then(1)`
	`4170`	`+elif(#"ceq" e1 e2: bool #)then(0)`
`4171`	`4171`	`elif(#"ceq" e2 e2: bool #)then(-1)`
`4172`	`4172`	`else(#"ceq" e1 e1: int #)`
`4173`	`4173`	`when^T: char=if(#"clt.un" e1 e2: bool #)then(-1)else(#"cgt.un" e1 e2: int #)`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -816,3 +816,16 @@ type RangeTests() =`
`816`	`816`	`if System.UIntPtr.Size>=8then RangeTestsHelpers.unsigned(System.UIntPtr System.UInt64.MinValue)(System.UIntPtr System.UInt64.MaxValue)`
`817`	`817`
`818`	`818`
	`819`	`+openNonStructuralComparison`
	`820`	`+`
	`821`	`+`
	`822`	`+[<TestFixture>]`
	`823`	`+typeNonStructuralComparisonTests()=`
	`824`	`+`
	`825`	`+[<Test>]`
	`826`	`+member__.CompareFloat32()=// https://github.com/Microsoft/visualfsharp/pull/4493`
	`827`	`+`
	`828`	`+letx=32\|> float32`
	`829`	`+lety=32\|> float32`
	`830`	`+letcomparison= compare x y`
	`831`	`+ Assert.AreEqual(0, comparison)`

Comments

(0)