Commit1fbaf0c

authored and

committed

Fix error logging in brace matching code (dotnet#4140)

* Remove error logger pushing code* Update service.fs

1 parentf9893b6 commit1fbaf0cCopy full SHA for 1fbaf0c

File tree

-0

lines changed

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1521,6 +1521,12 @@ module internal Parser =`
`1521`	`1521`
`1522`	`1522`	`letmatchBraces(source,fileName,options:FSharpParsingOptions,userOpName:string)=`
`1523`	`1523`	`Trace.TraceInformation("FCS: {0}.{1} ({2})", userOpName,"matchBraces", fileName)`
	`1524`	`+`
	`1525`	`+// Make sure there is an ErrorLogger installed whenever we do stuff that might record errors, even if we ultimately ignore the errors`
	`1526`	`+letdelayedLogger= CapturingErrorLogger("matchBraces")`
	`1527`	`+use _unwindEL= PushErrorLoggerPhaseUntilUnwind(fun _-> delayedLogger)`
	`1528`	`+use _unwindBP= PushThreadBuildPhaseUntilUnwind BuildPhase.Parse`
	`1529`	`+`
`1524`	`1530`	`letmatchingBraces=new ResizeArray<_>()`
`1525`	`1531`	`Lexhelp.usingLexbufForParsing(UnicodeLexing.StringAsLexbuf(addNewLine source), fileName)(fun lexbuf->`
`1526`	`1532`	`leterrHandler= ErrorHandler(false, fileName, options.ErrorSeverityOptions, source)`

Comments

(0)