Commit13b0ba0

authored and

committed

F# RFC FS-1029 - Implement IReadOnlyCollection<'T> in list<'T> (dotnet#2093)

* F# RFC FS-1029* added tests* dealing with the old portable library* simpler conditional

1 parent24d088f commit13b0ba0Copy full SHA for 13b0ba0

File tree

+32

-0

lines changed

+32

-0

lines changed

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,25 @@ type ListType() =`
`82`	`82`	`CheckThrowsInvalidOperationExn(fun()->enum.Current\|> ignore)`
`83`	`83`	`Assert.AreEqual(false,enum.MoveNext())`
`84`	`84`	`CheckThrowsInvalidOperationExn(fun()->enum.Current\|> ignore)`
	`85`	`+`
	`86`	`+ #if!FSCORE_PORTABLE_OLD`
	`87`	`+[<Test>]`
	`88`	`+memberthis.IReadOnlyCollection_T()=`
	`89`	`+`
	`90`	`+// Legit IReadOnlyCollection_T`
	`91`	`+letc=['a';'b';'c']:> IReadOnlyCollection<char>`
	`92`	`+`
	`93`	`+ Assert.AreEqual(c.Count, Seq.length c)`
	`94`	`+`
	`95`	`+letc=[1..10]:> IReadOnlyCollection<int>`
	`96`	`+`
	`97`	`+ Assert.AreEqual(c.Count,10)`
	`98`	`+`
	`99`	`+// Empty IReadOnlyCollection_T`
	`100`	`+letc=[]:> IReadOnlyCollection<int>`
	`101`	`+`
	`102`	`+ Assert.AreEqual(c.Count,0)`
	`103`	`+#endif`
`85`	`104`
`86`	`105`	`// Base class methods`
`87`	`106`	`[<Test>]`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3497,6 +3497,10 @@ namespace Microsoft.FSharp.Collections`
`3497`	`3497`	`\|(::): Head: 'T* Tail: 'T list-> 'T list`
`3498`	`3498`	`interface System.Collections.Generic.IEnumerable<'T>`
`3499`	`3499`	`interface System.Collections.IEnumerable`
	`3500`	`+`
	`3501`	`+#if!FSCORE_PORTABLE_OLD`
	`3502`	`+interface System.Collections.Generic.IReadOnlyCollection<'T>`
	`3503`	`+#endif`
`3500`	`3504`
`3501`	`3505`	`and 'T list= List<'T>`
`3502`	`3506`
`@@ -3690,6 +3694,11 @@ namespace Microsoft.FSharp.Collections`
`3690`	`3694`	`interface System.Collections.IEnumerablewith`
`3691`	`3695`	`memberl.GetEnumerator()=(PrivateListHelpers.mkListEnumerator l:> System.Collections.IEnumerator)`
`3692`	`3696`
	`3697`	`+#if!FSCORE_PORTABLE_OLD`
	`3698`	`+interface IReadOnlyCollection<'T>with`
	`3699`	`+memberl.Count= l.Length`
	`3700`	`+#endif`
	`3701`	`+`
`3693`	`3702`	`typeseq<'T>= IEnumerable<'T>`
`3694`	`3703`
`3695`	`3704`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1828,6 +1828,10 @@ namespace Microsoft.FSharp.Collections`
`1828`	`1828`
`1829`	`1829`	`interface System.Collections.Generic.IEnumerable<'T>`
`1830`	`1830`	`interface System.Collections.IEnumerable`
	`1831`	`+`
	`1832`	`+#if!FSCORE_PORTABLE_OLD`
	`1833`	`+interface System.Collections.Generic.IReadOnlyCollection<'T>`
	`1834`	`+#endif`
`1831`	`1835`
`1832`	`1836`	`///<summary>An abbreviation for the type of immutable singly-linked lists. </summary>`
`1833`	`1837`	`///`

Comments

(0)