Commit0c26a52

authored and

committed

Report better error for invalid = in for loop (dotnet#1934)

1 parente2da66e commit0c26a52Copy full SHA for 0c26a52

File tree

+16

-4

lines changed

+16

-4

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1332,4 +1332,5 @@ tcTupleStructMismatch,"One tuple type is a struct tuple, the other is a referenc`
`1332`	`1332`	`3211,DefaultParameterValueNotAppropriateForArgument,"The default value does not have the same type as the argument. The DefaultParameterValue attribute and any Optional attribute will be ignored. Note: 'null' needs to be annotated with the correct type, e.g. 'DefaultParameterValue(null:obj)'."`
`1333`	`1333`	`tcGlobalsSystemTypeNotFound,"The system type '%s' was required but no referenced system DLL contained this type"`
`1334`	`1334`	`3213,typrelMemberHasMultiplePossibleDispatchSlots,"The member '%s' matches multiple overloads of the same method.\nPlease restrict it to one of the following:%s."`
`1335`		`-3214,methodIsNotStatic,"Method or object constructor '%s' is not static"`
	`1335`	`+3214,methodIsNotStatic,"Method or object constructor '%s' is not static"`
	`1336`	`+3215,parsUnexpectedSymbolEqualsInsteadOfIn,"Unexpected symbol '=' in expression. Did you intend to use 'for x in y .. z do' instead?"`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3903,9 +3903,12 @@ forLoopBinder:`
`3903`	`3903`	`($1, arbExpr("forLoopBinder2",(rhs parseState 1).EndRange), false) }`
`3904`	`3904`
`3905`	`3905`	`forLoopRange:`
`3906`		`- \| parenPattern EQUALS declExprforLoopDirection declExpr`
	`3906`	`+ \| parenPattern EQUALS declExpr forLoopDirection declExpr`
`3907`	`3907`	`{ idOfPat (rhs parseState 1) $1,$3,$4,$5 }`
`3908`	`3908`
	`3909`	`+ \| parenPattern EQUALS rangeSequenceExpr`
	`3910`	`+ { raiseParseErrorAt (rhs parseState 2) (FSComp.SR.parsUnexpectedSymbolEqualsInsteadOfIn()) }`
	`3911`	`+`
`3909`	`3912`	`inlineAssemblyExpr:`
`3910`	`3913`	`\| HASH stringOrKeywordString opt_inlineAssemblyTypeArg opt_curriedArgExprs opt_inlineAssemblyReturnTypes HASH`
`3911`	`3914`	`{ libraryOnlyWarning (lhs parseState)`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,7 @@`
	`1`	`+// #Warnings`
	`2`	`+//<Expects status="Error" id="FS3215">Unexpected symbol '=' in expression. Did you intend to use 'for x in y .. z do' instead?</Expects>`
	`3`	`+`
	`4`	`+for i=0..100do`
	`5`	`+()`
	`6`	`+`
	`7`	`+exit0`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,8 @@`
`6`	`6`	`SOURCE=TupleInAbstractMethod.fs # TupleInAbstractMethod.fs`
`7`	`7`	`SOURCE=InvalidRecord.fs # InvalidRecord.fs`
`8`	`8`	`SOURCE=CommaInRecCtor.fs # CommaInRecCtor.fs`
`9`		`-SOURCE=MissingCommaInCtor.fs # MissingCommaInCtor.fs`
`10`		`-SOURCE=MissingCtorValue.fs # MissingCtorValue.fs`
	`9`	`+SOURCE=MissingCommaInCtor.fs # MissingCommaInCtor.fs`
	`10`	`+SOURCE=MissingCtorValue.fs # MissingCtorValue.fs`
`11`	`11`	`SOURCE=ExtraArgumentInCtor.fs # ExtraArgumentInCtor.fs`
`12`	`12`	`SOURCE=ExtraArgumentInCtor2.fs # ExtraArgumentInCtor2.fs`
`13`	`13`	`SOURCE=ValidCommaInRecCtor.fs # ValidCommaInRecCtor.fs`
`@@ -21,6 +21,7 @@`
`21`	`21`	`SOURCE=AccessOfTypeAbbreviation4.fs # AccessOfTypeAbbreviation4.fs`
`22`	`22`	`SOURCE=AccessOfTypeAbbreviation5.fs # AccessOfTypeAbbreviation5.fs`
`23`	`23`	`SOURCE=AccessOfTypeAbbreviation6.fs # AccessOfTypeAbbreviation6.fs`
	`24`	`+SOURCE=EqualsInsteadOfInInForLoop.fs # EqualsInsteadOfInInForLoop.fs`
`24`	`25`	`SOURCE=DontWarnExternalFunctionAsUnused.fs SCFLAGS="--warnon:1182 --warnaserror+" # DontWarnExternalFunctionAsUnused.fs`
`25`	`26`	`SOURCE=SuggestTypesInModule.fs # SuggestTypesInModule.fs`
`26`	`27`	`SOURCE=SuggestGenericType.fs # SuggestGenericType.fs`

Comments

(0)