Commit0a8c0fa

authored and

committed

Remove double lookups from NameResolution (dotnet#4751)

1 parent8cbb761 commit0a8c0faCopy full SHA for 0a8c0fa

File tree

-15

lines changed

-15

lines changed

Lines changed: 6 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -4445,21 +4445,12 @@ let rec GetCompletionForItem (ncenv: NameResolver) (nenv: NameResolutionEnv) m a`
`4445`	`4445`	`else Seq.empty)`
`4446`	`4446`
`4447`	`4447`	`// Look for values called 'id' that accept the dot-notation`
`4448`		`-letvalues,isItemVal=`
`4449`		`-(if nenv.eUnqualifiedItems.ContainsKey(id)then`
`4450`		`-// v.lookup : member of a value`
`4451`		`-letv= nenv.eUnqualifiedItems.[id]`
`4452`		`-match vwith`
`4453`		`-\| Item.Value x->`
`4454`		`-lettyp= x.Type`
`4455`		`-lettyp=if x.BaseOrThisInfo= CtorThisVal&& isRefCellTy g typthen destRefCellTy g typelse typ`
`4456`		`-(ResolvePartialLongIdentInTypeForItem ncenv nenv m adfalse rest item typ),true`
`4457`		`-\|_-> Seq.empty,false`
`4458`		`-else Seq.empty,false)`
`4459`		`-`
`4460`		`-yield! values`
`4461`		`-`
`4462`		`-ifnot isItemValthen`
	`4448`	`+match Map.tryFind id nenv.eUnqualifiedItemswith`
	`4449`	`+\| Some(Item.Value x)->`
	`4450`	`+lettyp= x.Type`
	`4451`	`+lettyp=if x.BaseOrThisInfo= CtorThisVal&& isRefCellTy g typthen destRefCellTy g typelse typ`
	`4452`	`+yield! ResolvePartialLongIdentInTypeForItem ncenv nenv m adfalse rest item typ`
	`4453`	`+\|_->`
`4463`	`4454`	`// type.lookup : lookup a static something in a type`
`4464`	`4455`	`for tcrefin LookupTypeNameInEnvNoArity OpenQualified id nenvdo`
`4465`	`4456`	`lettcref= ResolveNestedTypeThroughAbbreviation ncenv tcref m`

Comments

(0)