Commit0a8adb6

authored and

committed

Fix FSharpMemberOrFunctionOrValue.IsConstructor property for ctor definition (dotnet#3972)

* fix FSharpMemberOrFunctionOrValue.IsConstructor property for ctor definition* add a test

1 parenta7a6586 commit0a8adb6Copy full SHA for 0a8adb6

File tree

+32

-0

lines changed

+32

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1796,6 +1796,7 @@ and FSharpMemberOrFunctionOrValue(cenv, d:FSharpMemberOrValData, item) =`
`1796`	`1796`	`memberx.IsConstructor=`
`1797`	`1797`	`match dwith`
`1798`	`1798`	`\| C_->true`
	`1799`	`+\| V v-> v.IsConstructor`
`1799`	`1800`	`\|_->false`
`1800`	`1801`
`1801`	`1802`	`memberx.Data= d`

Lines changed: 31 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -715,6 +715,37 @@ type Class1() =`
`715`	`715`	`("member .cctor",(10,5,10,11))`
`716`	`716`	`("Test",(1,0,1,0))\|]`
`717`	`717`
	`718`	`+[<Test>]`
	`719`	+let``IsConstructor property should return true for constructors``()=
	`720`	`+letinput=`
	`721`	`+"""`
	`722`	`+type T(x: int) =`
	`723`	`+ new() = T(0)`
	`724`	`+let x: T()`
	`725`	`+"""`
	`726`	`+letfile="/home/user/Test.fsx"`
	`727`	`+let_,typeCheckResults= parseAndCheckScript(file, input)`
	`728`	`+ typeCheckResults.GetAllUsesOfAllSymbolsInFile()`
	`729`	`+\|> Async.RunSynchronously`
	`730`	`+\|> Array.map(fun su->`
	`731`	`+letr= su.RangeAlternate`
	`732`	`+letisConstructor=`
	`733`	`+match su.Symbolwith`
	`734`	`+\|:? FSharpMemberOrFunctionOrValueas f-> f.IsConstructor`
	`735`	`+\|_->false`
	`736`	`+ su.Symbol.ToString(),(r.StartLine, r.StartColumn, r.EndLine, r.EndColumn), isConstructor)`
	`737`	`+\|> Array.distinct`
	`738`	`+\|> shouldEqual`
	`739`	`+[\|("T",(2,5,2,6),false)`
	`740`	`+("int",(2,10,2,13),false)`
	`741`	`+("val x",(2,7,2,8),false)`
	`742`	`+("member .ctor",(2,5,2,6),true)`
	`743`	`+("member .ctor",(3,4,3,7),true)`
	`744`	`+("member .ctor",(3,12,3,13),true)`
	`745`	`+("T",(4,7,4,8),false)`
	`746`	`+("val x",(4,4,4,5),false)`
	`747`	`+("Test",(1,0,1,0),false)\|]`
	`748`	`+`
`718`	`749`	`//-------------------------------------------------------------------------------`
`719`	`750`
`720`	`751`

Comments

(0)